From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id BFF68385828C for ; Wed, 10 Aug 2022 19:46:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BFF68385828C Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27AIjBfI006486 for ; Wed, 10 Aug 2022 19:46:58 GMT Received: from ppma05wdc.us.ibm.com (1b.90.2fa9.ip4.static.sl-reverse.com [169.47.144.27]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3hv1fw1hfh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 10 Aug 2022 19:46:57 +0000 Received: from pps.filterd (ppma05wdc.us.ibm.com [127.0.0.1]) by ppma05wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 27AJKmTm015848 for ; Wed, 10 Aug 2022 19:46:56 GMT Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by ppma05wdc.us.ibm.com with ESMTP id 3hvcmra1m2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 10 Aug 2022 19:46:56 +0000 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 27AJktDS8520374 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Aug 2022 19:46:55 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4B36F2805C; Wed, 10 Aug 2022 19:46:55 +0000 (GMT) Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D59D12805A; Wed, 10 Aug 2022 19:46:54 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.211.44.164]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 10 Aug 2022 19:46:54 +0000 (GMT) Message-ID: <47fd087cd94544b980aab5eed9f6113ab5a183f9.camel@us.ibm.com> Subject: Re: [PATCH ver 2] Fix hardware watchpoint check in test gdb.base/watchpoint-reuse-slot.exp From: Carl Love To: "gdb-patches@sourceware.org" , Ulrich Weigand Date: Wed, 10 Aug 2022 12:46:54 -0700 In-Reply-To: <3783e7e44fe188af5ca1f2ddcfa4c7f5cb7a818e.camel@us.ibm.com> References: <3783e7e44fe188af5ca1f2ddcfa4c7f5cb7a818e.camel@us.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 8dLpvADJW5RkZer84mySfnAdDYg8lW-O X-Proofpoint-GUID: 8dLpvADJW5RkZer84mySfnAdDYg8lW-O X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-10_13,2022-08-10_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxlogscore=727 adultscore=0 impostorscore=0 suspectscore=0 bulkscore=0 spamscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 lowpriorityscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208100059 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2022 19:47:00 -0000 GDB maintainers, Will: I have updated the patch per comments from Will. The gdb.base/watchpoint-reuse-slot.exp uses the check: if { ![target_info exists gdb,no_hardware_watchpoints]} to determine if the test should be run with HW watchpoints. The target_info exists check for HW watchpoints is TRUE on Power 9. However HW watchpoints are disabled on Power 9 due to a HW bug. The skip_hw_watchpoint_access_tests check needs to be used to properly determine if HW watchpoints are supported by the processor. If the processor is PowerPC, the skip_hw_watchpoint_access_tests will run small gdb test if the processor supports HW watchpoints. On other platforms, the skip_hw_watchpoint_access_tests checks the list of processors that support HW watchpoints. This patch replaces the [target_info exists gdb, no_hardware_watchpoints] with the skip_hw_watchpoint_access_tests check to properly determine if the processor supports HW watchpoints. The fix disables the HW watchpoint tests on Power 9 thus eliminating 48 testsuite failures. The patch has been tested on Power 9, Power 10 and x86-64 Please let me know if this patch is acceptable for mainline. Thanks. Carl Love --------------------------------------------------------------- Fix hardware watchpoint check in test gdb.base/watchpoint-reuse-slot.exp This test generates 48 failures on Power 9 when testing with HW watchpoints enabled. Note HW watchpoint support is disabled on Power 9 due to a HW bug. The skip_hw_watchpoint_access_tests proc must be used to correctly determine if the processor supports HW watchpoints. This patch replaces the [target_info exists gdb,no_hardware_watchpoints] with the skip_hw_watchpoint_access_tests check. This patch was tested on Power 9, Power 10 and X86-64 with no regressions. --- gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp b/gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp index e2ea137424b..3d095d2ce9e 100644 --- a/gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp +++ b/gdb/testsuite/gdb.base/watchpoint-reuse-slot.exp @@ -22,6 +22,20 @@ # operation. (Note that we don't have any of these watchpoints # trigger.) +# The skip_hw_watchpoint_tests checks if watchpoints are supported by the +# processor. On PowerPC, the check runs a small test program under gdb +# to determine if the Power processor supports HW watchpoints. The check +# must be done before starting the test so as to not disrupt the execution +# of the actual test. + +if {[skip_hw_watchpoint_access_tests]} { + set supports_hw_wp 0 +} else { + set supports_hw_wp 1 +} + +# starting the test. + standard_testfile if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} { @@ -285,7 +299,7 @@ proc setup_and_run_watchpoints_tests { hw_wp_p } { # Run tests with hardware watchpoints disabled, then again with them # enabled (if this target supports hardware watchpoints). -if { ![target_info exists gdb,no_hardware_watchpoints]} { +if { $supports_hw_wp } { # Run test with H/W enabled. setup_and_run_watchpoints_tests 1 } -- 2.31.1