From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116156 invoked by alias); 15 Oct 2018 19:54:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116126 invoked by uid 89); 15 Oct 2018 19:54:14 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Oh, oh, life, HContent-Transfer-Encoding:8bit X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 15 Oct 2018 19:54:12 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B8B17AD91; Mon, 15 Oct 2018 19:54:10 +0000 (UTC) Subject: Re: [PATCH][gdb/testsuite] Rewrite catch-follow-exec.exp To: Simon Marchi , Gary Benson Cc: gdb-patches@sourceware.org, Pedro Alves References: <20181005101122.GA23867@delia> <20181009135155.GB12668@blade.nx> <8f8ffb94-5a0c-8b2b-d541-eaacd7d1f42c@suse.de> <20181010092735.GA29557@blade.nx> <20181010134423.GA23926@blade.nx> <20181011074744.GA7677@delia> <20181011083318.GA13751@blade.nx> <06b38d2e3f0a9394280553e70b9dfaf8@polymtl.ca> From: Tom de Vries Message-ID: <480ea2be-eac0-8d19-cfe7-93c56b33a7ac@suse.de> Date: Mon, 15 Oct 2018 19:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <06b38d2e3f0a9394280553e70b9dfaf8@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00335.txt.bz2 On 10/14/18 12:18 AM, Simon Marchi wrote: > On 2018-10-11 04:33, Gary Benson wrote: >> Tom de Vries wrote: >>> On Wed, Oct 10, 2018 at 02:44:24PM +0100, Gary Benson wrote: >>> > Oh!  Ok, so [target_info gdb_protocol] != ""] maybe? >>> >>> Attached patch uses this this. >>> >>> OK for trunk? >> >> Please reorder the checks at the start like this, to minimize the >> work done before bailing: >> >>   1. check gdb_protocol native >>   2. check /bin/ls exists on target >>   3. build_executable >> >> The patch is ok by me with these changes, but please wait for a >> maintainer to give the final approval, I don't have those powers :) >> And thanks for doing the work Tom! >> >> Cheers, >> Gary > > Just wondering.  Would it make life easier if we fixed PR 23368, which > is the reason we have to do the test in an unnatural way? Yes. > I don't know > if the fix I proposed here is totally correct: > > https://sourceware.org/bugzilla/show_bug.cgi?id=23368#c4 > > but I think it would be an improvement compared to what we have now.  I > ran it through the buildbot and there are no regressions.  If you want I > can submit a proper patch for that, and then we can rewrite this test in > a more normal way. > That makes sense, but also I propose to commit the patch I've submitted (with the early-out checks reorder as Gary suggested above), since that's also an improvement on the current situation. OK? Thanks, - Tom