From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by sourceware.org (Postfix) with ESMTPS id 2C4773858025 for ; Wed, 15 Feb 2023 19:54:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2C4773858025 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qt1-x829.google.com with SMTP id m12so23044602qth.4 for ; Wed, 15 Feb 2023 11:54:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=dscwNgLO8vLCISS6ZmPLYxpS6H7x8mK99qOn3OcPRic=; b=MJzsbtb29Zxzqlk1o7uSlsq+PGSVmsoFEbTFOke8skOMeMddVQu+sLqGP7Rp5kZUJt CVUoMFkedllGkyv9GnP2C7igbCrmeKx9gMUu+xEDeQPRvtRzFxtVcSKcxN1RBkiiIAhh +8LZLEHhqw5iL4LReSEvNSB28+i4YnMuUtVHxkXp657fF2WLESR98Ui3UZKdl2IHfNNK OFyudDmM//cYX6zF/ANwJMCxGscniO+MLrZX9PmhaVpKEBDb5pjGRx0mb4zkzL/kZRHk irUm2ZOvc95CxZbZdKTf7uRJJW94bHnLzwNrVFqR8KzIwQZNjXk1RvLQuwS1BS+FxQZL sXtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dscwNgLO8vLCISS6ZmPLYxpS6H7x8mK99qOn3OcPRic=; b=FvbmnbuYAPe3b7Ft30PhZo1j1AZWuZUBeCUi7IfxN5BFrxZW5DpJmYkxwjdoJMFbZr WapdwsS2pTUBrXokppZ3MbdtLzhTUX6uhN/IS9f/oVve0urJdUA5vIeDh73KcsCAU9h+ 91GeVN/bxBmHeoHUz2evmBdvpQzdZwBsHAA++seA/Urp2idcBkQSN8oHbP9dVKhWhIQg FWXbzNCOdWpu1xL902D764oX+VdaCsf0eqTZh3l40fMrVhx1alGOTldON/6o12A+WLw2 GLAvrbkDQFya/SohWjmu+gWV2ECidKUe+1owooZikWwdal8vLlzjVyZ8l40O3NE1VueP qQXw== X-Gm-Message-State: AO0yUKWRJukiTgYqixOXX10+Cll6AozjZknfw8uJF9DImI2gXYOSI0SH FgogPizAB+bdT8j4aWQFfcdW7Zm9EvE= X-Google-Smtp-Source: AK7set/cYkWQltEJ0z+NV4PPbjSGxUZG5Zzt4pUymOvIsNWx/1eWqsdIsTppn3gUB6DKKxFY98+ZYw== X-Received: by 2002:a05:622a:88:b0:3b9:b7e8:3b38 with SMTP id o8-20020a05622a008800b003b9b7e83b38mr5670818qtw.50.1676490871408; Wed, 15 Feb 2023 11:54:31 -0800 (PST) Received: from [192.168.1.127] (173-246-5-136.qc.cable.ebox.net. [173.246.5.136]) by smtp.gmail.com with ESMTPSA id 78-20020a370a51000000b00706b09b16fasm14462502qkk.11.2023.02.15.11.54.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Feb 2023 11:54:30 -0800 (PST) Subject: Re: [PATCH] gdb: add --with-curses to --configuration output To: Simon Marchi , gdb-patches@sourceware.org References: <20230211-configuration-show-curses-v1-1-ce1bc0c062ac@gmail.com> <0b0c4556-4d34-671d-8632-eb5d44251cfa@simark.ca> From: Philippe Blain Message-ID: <482367e3-fd84-011c-56a2-f181cf86a68a@gmail.com> Date: Wed, 15 Feb 2023 14:54:29 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <0b0c4556-4d34-671d-8632-eb5d44251cfa@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Simon, Le 2023-02-15 à 13:58, Simon Marchi a écrit : >> diff --git a/gdb/configure.ac b/gdb/configure.ac >> index 7c7bf88b3fb..eac1b8f1aba 100644 >> --- a/gdb/configure.ac >> +++ b/gdb/configure.ac >> @@ -563,7 +563,10 @@ if test x"$prefer_curses" = xyes; then >> # search /usr/local/include, if ncurses is installed in /usr/local. A >> # default installation of ncurses on alpha*-dec-osf* will lead to such >> # a situation. >> - AC_SEARCH_LIBS(waddstr, [ncursesw ncurses cursesX curses]) >> + AC_SEARCH_LIBS(waddstr, [ncursesw ncurses cursesX curses], >> + [AC_DEFINE([HAVE_LIBCURSES], [1], >> + [Define to 1 if curses is enabled.]) >> + ]) > > So we now have: > > AC_SEARCH_LIBS(waddstr, [ncursesw ncurses cursesX curses], > [AC_DEFINE([HAVE_LIBCURSES], [1], > [Define to 1 if curses is enabled.]) > ]) > > if test "$ac_cv_search_waddstr" != no; then > curses_found=yes > fi > > I think the `if test ...` serves the same purpose as the action-if-found > you used. Perhaps consolidate both actions to use the same mechanism? > Using the action-if-found parameter seems a bit nicer to me. Yes, this makes sense. I'll do that for v2. Philippe.