From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 8F5533858D20 for ; Tue, 14 Nov 2023 15:00:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F5533858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8F5533858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:67c:2178:6::1d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699974035; cv=none; b=Lv5v35NuQ+3bGc+5k0z3jbDexLvb4A7GdzFloedw8nZhdGGGqixyd0EWpSPCcaz+iC1qRbglsCBAblSLY5KOeSna8+j73eZ3UKoE650sr0BsTu6gpwzuj01i8xG04dFGnDwSzdRtWXonCgNEc9OTigvRl/cABfwoEaqqxkxUsnc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699974035; c=relaxed/simple; bh=0x2Ho88JrSRC0gHhBX/eME1Ed0rsLiVyL2SbacYjAyc=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=N7zyZmr8WQpNdQVjOkaKMph4B122JHPkDLv8Pf+pFGeDXlGrKTRpBBbrhIHcVflzdZ1oICZsSgkTvzBGvFmwFg1vgxL0XmdIW0xxeLeW4qXJLaVoEqZXmibXod1s9rSVw36XjPcVJ1UQUiExOg7a893ZLa3oB0dUmrp1IJAI1Ko= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A253320430; Tue, 14 Nov 2023 15:00:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1699974029; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jOGhYZMhmBPPkbNT0GWwJqVqt7K6ODLYWmwawoRU3LM=; b=cxy7epApiPUxFTcDkdxEiUprcZSQgG6KT8IOlpfQkhdn/jaKF5iAGte2KmU19pPmJiA7SV JzCLu37dof8vZffu84FUnCf9u1z0EeO9c8l1zvNyGjsIym7qUK1JXxzsF1u/NHZgkc80wr ZTCKIT/ML6W7YwXihkE2jCSOtnXKRkU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1699974029; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jOGhYZMhmBPPkbNT0GWwJqVqt7K6ODLYWmwawoRU3LM=; b=VHBaTDZYL2L2Ki6kyT6hKdp9XDITDg2KtPPapH1yWHXVIMtlz/5oyUOE1rRlb1sglFexfP oZJH/GrQcH38ghAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8BA9613416; Tue, 14 Nov 2023 15:00:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hBniII2LU2W8QAAAMHmgww (envelope-from ); Tue, 14 Nov 2023 15:00:29 +0000 Message-ID: <486deaa5-f191-4625-9e90-3fad2c4abc2b@suse.de> Date: Tue, 14 Nov 2023 16:02:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/tui] Factor out tui_noscroll_window et al Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20231112150601.25484-1-tdevries@suse.de> <87msvhtw9w.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87msvhtw9w.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -4.87 X-Spamd-Result: default: False [-4.87 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-0.78)[84.44%]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-3.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/13/23 18:09, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> Evidently, this introduces multiple inheritance. > > Tom> Here ( https://gcc.gnu.org/codingconventions.html#CandCxx ) we read: > > FWIW you can't really go by the GCC conventions. GCC is a lot more > conservative about C++ than GDB is. > I came across it via https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#C.2B-.2B--specific_coding_conventions : ... C++-specific coding conventions GDB follows GCC's C++ coding conventions, diverging only on finer detail, as we find necessary. See these documents, which have extensive detail: GCC's C++ Language Conventions (scroll down a bit) GCC Coding Conventions Rationale and Discussion A point where we diverge is in permitting the use of C++ exceptions. ... So I suppose this is one of those finer details ;) Thanks, - Tom > Tom> I think the newly introduced classes are close enough to the traits > Tom> concept described above for the multiple inheritance to be acceptable. > > Makes sense to me. And FWIW GDB already uses multiple inheritance. > > Tom