From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2059.outbound.protection.outlook.com [40.107.21.59]) by sourceware.org (Postfix) with ESMTPS id 436CC3858033 for ; Wed, 23 Nov 2022 12:47:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 436CC3858033 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LJIrX5xTwfBDh4DbnSQUh8Ttuuvagax9FeZSZs/chsM=; b=Kct7QHkLdKBaGqg3KDDPOcjpjC4sMMmisgYtryAn4rKh1fkibYlLrNdxG1d3NO2P1EMQKipc8HH9kqzxjZfGbGWEpru3XQrLelOt9lpDMO9K3U+hsm8V7zOK/22YtUyOntm1VpGP5turgYo9Ha3KK8RJUALo0XS67o5/Ef/rIxg= Received: from DB9PR06CA0027.eurprd06.prod.outlook.com (2603:10a6:10:1db::32) by AM8PR08MB6449.eurprd08.prod.outlook.com (2603:10a6:20b:364::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 12:47:15 +0000 Received: from DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1db:cafe::12) by DB9PR06CA0027.outlook.office365.com (2603:10a6:10:1db::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17 via Frontend Transport; Wed, 23 Nov 2022 12:47:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT054.mail.protection.outlook.com (100.127.142.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.18 via Frontend Transport; Wed, 23 Nov 2022 12:47:15 +0000 Received: ("Tessian outbound 6c699027a257:v130"); Wed, 23 Nov 2022 12:47:15 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b608cef03f963433 X-CR-MTA-TID: 64aa7808 Received: from 32603b5bfc2c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0F87381C-7D9F-4EBA-B860-12BAC187EE4F.1; Wed, 23 Nov 2022 12:47:09 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 32603b5bfc2c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 23 Nov 2022 12:47:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ogk+weU9hN7CkseZlSlTiys9X0d8k3idsy/Za25mBdaMDKSgagMZ37GwN8y+E146UwTvNRE2q/sAat6ZhESABLz2Rc6t1dKDJFhEnBzcTcn5KmpdNzjSbk0Meh/opzvEMgdDw5TyJUtcqS3xcS9SGaAulKU6wvRC18NNZWQ8iafcG1oZxoaMw7wzO4ni+0Id06HNtkkyeajgltDLTJX4UPb8wvL/R9QRE94KQ//h9lpz84y+4mmBbYwY4qysRDsSxDk/tcvyHrk20YKWcyWcpDOVaHjQGpSgul5PwfuXyan6qwnPgrQrX7CF4HD16kQ2LVmm588roNsltG74LQ9D2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LJIrX5xTwfBDh4DbnSQUh8Ttuuvagax9FeZSZs/chsM=; b=oF4N2Nm9W+j5yOGcib4LTD2NNItdf1dwB+sbySRhEPvavZqB5E8zDOTZt6pwKyhe+6z9UwId2Bn4/E5D9LStVbbXv7gUzDbMlYet0a6mc4ZyscGjJ2CxlqSPzRcPN2HbJhnCFsmQ2s8I/pM0iB09cGj0o2e8m9ERIFu0fx0VRDCyTErrtT5WnmOFL/bCJg6jYOHzRov16nUT/L+f5rH8megVYA2mXVbiDO9zXsvu8UamjBYLsiRSKz2ETdBqfTCD1+k5mjtnbG5iL+gM3DrEEXFsrv76EHPDoHf1JaWh1c9CUI/ujjYt91QwfDJoclrYsyqs4U8GVXndSRN/V3UTuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LJIrX5xTwfBDh4DbnSQUh8Ttuuvagax9FeZSZs/chsM=; b=Kct7QHkLdKBaGqg3KDDPOcjpjC4sMMmisgYtryAn4rKh1fkibYlLrNdxG1d3NO2P1EMQKipc8HH9kqzxjZfGbGWEpru3XQrLelOt9lpDMO9K3U+hsm8V7zOK/22YtUyOntm1VpGP5turgYo9Ha3KK8RJUALo0XS67o5/Ef/rIxg= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DU0PR08MB8043.eurprd08.prod.outlook.com (2603:10a6:10:3e7::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Wed, 23 Nov 2022 12:47:02 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c470:cc90:a9ad:6dd1]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c470:cc90:a9ad:6dd1%4]) with mapi id 15.20.5857.017; Wed, 23 Nov 2022 12:47:02 +0000 Message-ID: <486f9e2a-bc89-290a-b08a-1c90785c125d@arm.com> Date: Wed, 23 Nov 2022 12:46:59 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2] gdb/arm: Include FType bit in EXC_RETURN pattern on v8m Content-Language: en-US To: =?UTF-8?Q?Torbj=c3=b6rn_SVENSSON?= , gdb-patches@sourceware.org References: <20221123121728.2459860-1-torbjorn.svensson@foss.st.com> From: Luis Machado In-Reply-To: <20221123121728.2459860-1-torbjorn.svensson@foss.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P123CA0103.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:139::18) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|DU0PR08MB8043:EE_|DBAEUR03FT054:EE_|AM8PR08MB6449:EE_ X-MS-Office365-Filtering-Correlation-Id: 8837f769-636a-493d-3eac-08dacd50d989 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +kLCy20ZMSDFr4Wx81vhUqS2Mvd7O71GLYFOeiiDOn9C2zFocZ0QzI/WE7JRx2cgOy4/JTE8NWGuyG9QjDrz09iN6Jug9b5edpL4dM57HSvOgLB0e1i5mjeRvANd1gkfrPl/ta361fE7tl7deMj7K9s6UgpeD/25qMXV+dWH0cdjtF0Wq19yUufCr357GZYGQ83J7vhZ2W8q/laURnThHUwvXm6jwlpIVt93I6Rx/V/X7cBDeybCsiQu2W084cQZM+Sdgyc7+V3pg8rPydvF3UFXCyA+R+exIrKdCthOww3jBdfgGqiaAFOpe9wSUQS94HUWYMpIAlFgfsStVxUmk7NDBnlCSnIFc77fA4/R+3WIC5XMiJD9Zsf30YEROPAoVdzEszsriJ16IpoYOKiPbdOJs1topaOYXGroAmjR2kqlGokaUy88qKs2z5ufjRTHfslFaP50BBp/KF9/VNX2Ta87StjXc/XvqIKC1KVM74ZcuDAh5oPahwK3bZvssotkIcbLx1SjXii09rhNil3f2We+p1pE2nQZyZT6etRPgDPMSqgMFoqctu8aPCAJs/j+qt/EOXods4CB37XK2O8SLUvj6zbRL7cWxPaAb1amImJQhcNQZA3rSeDZQ3We/0EWDunvEnHIwWwKVkTEDP00EyD39WTEp+/MKcj1oJeNlWAJvUoVnmXXKJTUBT+m6oz7sChLggNHsZwQoR/iTWXJzgN+C8KZ6fyuTM0crsguUuQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(396003)(376002)(136003)(346002)(366004)(451199015)(6506007)(478600001)(6486002)(6666004)(53546011)(26005)(186003)(66574015)(2906002)(36756003)(6512007)(38100700002)(83380400001)(31696002)(86362001)(2616005)(8936002)(41300700001)(44832011)(66556008)(66946007)(66476007)(8676002)(31686004)(5660300002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8043 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 89703a0a-3e94-4ca1-d1ad-08dacd50d198 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mGMxNQ4VPuVnJ9xjISMBnyDVBGj80wksKsrz+6haOTvYGrm2Zd0cYBVtQ0f+OTWtumCdw0p0pLJYCYFsOEekMfzwNxT0COqyMPQv/wH63ud4sn74A6fuHdZE76czYOCZYZe84QEznW5t84yJgRFQ6bWPLtiPji5MzJTADU8FUHgQ0Ss4BKUbbOj4qPQVEuDV86QM0Zbv289xg2H/+lxp4U2XGssG55Axa83H3wJ8J023ie3eLAOfWC3Z1uagywCHmspGDYyzw93DiZGXhJ7GLPwcQPDmgwLUZcU/fTA5howo/CiA4ra2SYFew+74b6ziT/vo8iBb6uWer5REK9QRTbddnkq+HH9TOTLt6nOcEF5PWtx8cm+zMuqUbGGeFKpnJFqUgJwNyaeAwbbtskb18A7fdihe5p4KCdaq2KjtdMWZVsa9jmAzl2Qdegy1+sq7MggqqsjuDdF1OiXpj1NbftBv1OA1AAg2y5M/xtfTiKweoqAcTHB5cJd/iX60Z1BlN4mWc1wCuocWV9mbQdJkLDZS5m684d62kDc12WHmEIZUwm0wfvMwSuVQGj//DkRKj3oOdH0EVWZrrG9hsMV57UCy8qEemFUfLmU8PBhfIXrt1OtevFnc6vBxSDO/kJZQueFrdXmXwhFzYv7G0wxZQNa8TCscV1oolqLfXra4HzK6s81SYlzaAWCQZL6/iF3YOAqrC/qjiXp8r1j63MpHFZhhfj0uJs9Ehmu2S7i48Uo= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(376002)(39860400002)(396003)(451199015)(46966006)(40470700004)(36840700001)(36860700001)(83380400001)(66574015)(86362001)(82740400003)(47076005)(41300700001)(81166007)(31696002)(2906002)(44832011)(8936002)(478600001)(6512007)(6506007)(5660300002)(82310400005)(40480700001)(40460700003)(53546011)(6666004)(2616005)(336012)(186003)(8676002)(70586007)(316002)(26005)(6486002)(356005)(70206006)(36756003)(31686004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2022 12:47:15.7074 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8837f769-636a-493d-3eac-08dacd50d989 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6449 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/23/22 12:17, Torbjörn SVENSSON wrote: > For v8m, the EXC_RETURN pattern, without security extension, consists of > FType, Mode and SPSEL. These are the same bits that are used in v7m. > This patch extends the list of patterns to include also the FType bit > and not just Mode and SPSEL bits for v8m targets without security > extension. > > Signed-off-by: Torbjörn SVENSSON > --- > gdb/arm-tdep.c | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) > > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index a839f957440..f466b5938e4 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -828,13 +828,17 @@ arm_m_addr_is_lockup (CORE_ADDR addr) > For more details see "B1.5.8 Exception return behavior" > in both ARMv6-M and ARMv7-M Architecture Reference Manuals. > > - In the ARMv8-M Architecture Technical Reference also adds > - for implementations without the Security Extension: > + From ARMv8-M Architecture Technical Reference, D1.2.95 > + FType, Mode and SPSEL bits are to be considerd when Security Extension is considerd -> considered when -> when the > + not implemented. > > - EXC_RETURN Condition > - 0xFFFFFFB0 Return to Handler mode. > - 0xFFFFFFB8 Return to Thread mode using the main stack. > - 0xFFFFFFBC Return to Thread mode using the process stack. */ > + EXC_RETURN Return To Return Stack Frame Type > + 0xFFFFFFA0 Handler mode Main Extended > + 0xFFFFFFA8 Thread mode Main Extended > + 0xFFFFFFAC Thread mode Process Extended > + 0xFFFFFFB0 Handler mode Main Standard > + 0xFFFFFFB8 Thread mode Main Standard > + 0xFFFFFFBC Thread mode Process Standard */ > > static int > arm_m_addr_is_magic (struct gdbarch *gdbarch, CORE_ADDR addr) > @@ -859,6 +863,9 @@ arm_m_addr_is_magic (struct gdbarch *gdbarch, CORE_ADDR addr) > switch (addr) > { > /* Values from ARMv8-M Architecture Technical Reference. */ > + case 0xffffffa0: > + case 0xffffffa8: > + case 0xffffffac: > case 0xffffffb0: > case 0xffffffb8: > case 0xffffffbc: OK with the above addressed.