From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
To: gdb-patches@sourceware.org
Cc: palves@redhat.com, tdevries@suse.de
Subject: [PATCH v5 2/5] gdb/infrun: move a 'regcache_read_pc' call down to first use
Date: Mon, 6 Apr 2020 17:45:48 +0200 [thread overview]
Message-ID: <48a722182b3cc68d5d2ebffa7161857087e417e1.1586187408.git.tankut.baris.aktemur@intel.com> (raw)
In-Reply-To: <cover.1586183975.git.tankut.baris.aktemur@intel.com>
In-Reply-To: <cover.1586187408.git.tankut.baris.aktemur@intel.com>
In infrun.c's resume_1 function, move the definition of the local
variable PC down to its first use. This is useful if the thread we want
to resume is already gone with a pending exit event, because we avoid
the error we would see otherwise when trying to read the PC.
gdb/ChangeLog:
2020-04-03 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
* infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
use.
---
gdb/infrun.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gdb/infrun.c b/gdb/infrun.c
index d6265c6df51..f5d3b79e0d0 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -2271,7 +2271,6 @@ resume_1 (enum gdb_signal sig)
struct regcache *regcache = get_current_regcache ();
struct gdbarch *gdbarch = regcache->arch ();
struct thread_info *tp = inferior_thread ();
- CORE_ADDR pc = regcache_read_pc (regcache);
const address_space *aspace = regcache->aspace ();
ptid_t resume_ptid;
/* This represents the user's step vs continue request. When
@@ -2350,6 +2349,8 @@ resume_1 (enum gdb_signal sig)
step = 0;
}
+ CORE_ADDR pc = regcache_read_pc (regcache);
+
if (debug_infrun)
fprintf_unfiltered (gdb_stdlog,
"infrun: resume (step=%d, signal=%s), "
--
2.17.1
next prev parent reply other threads:[~2020-04-06 15:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 15:45 [PATCH v5 0/5] Handling already-exited threads in 'stop_all_threads' Tankut Baris Aktemur
[not found] ` <cover.1586187408.git.tankut.baris.aktemur@intel.com>
2020-04-06 15:45 ` [PATCH v5 1/5] gdb: protect some 'regcache_read_pc' calls Tankut Baris Aktemur
2020-04-16 16:11 ` Pedro Alves
2020-04-20 20:13 ` Aktemur, Tankut Baris
2020-04-06 15:45 ` Tankut Baris Aktemur [this message]
2020-04-16 16:12 ` [PATCH v5 2/5] gdb/infrun: move a 'regcache_read_pc' call down to first use Pedro Alves
2020-04-06 15:45 ` [PATCH v5 3/5] gdb/remote: do not delete a thread if it has a pending event Tankut Baris Aktemur
2020-04-16 16:24 ` Pedro Alves
2020-04-20 20:35 ` Aktemur, Tankut Baris
2020-04-21 18:54 ` Pedro Alves
2020-04-22 14:57 ` Aktemur, Tankut Baris
2020-04-06 15:45 ` [PATCH v5 4/5] gdb/infrun: extract out a code piece into 'mark_non_executing_threads' function Tankut Baris Aktemur
2020-04-16 16:24 ` Pedro Alves
2020-04-06 15:45 ` [PATCH v5 5/5] gdb/infrun: handle already-exited threads when attempting to stop Tankut Baris Aktemur
2020-04-16 17:06 ` Pedro Alves
2020-04-20 20:43 ` Aktemur, Tankut Baris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48a722182b3cc68d5d2ebffa7161857087e417e1.1586187408.git.tankut.baris.aktemur@intel.com \
--to=tankut.baris.aktemur@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).