From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by sourceware.org (Postfix) with ESMTPS id 195AE385828A for ; Fri, 23 Feb 2024 17:02:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 195AE385828A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 195AE385828A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708707750; cv=none; b=fb/Oedx5KqJs0OS9t01fKeDwtS7nhzBnrUgzvPdRmbbLKYLSv7YHE8Nx/Z4Op9NrzB6mqOy3nmphRhK5zgmZGBbQeDilmzbiJSKXsDit7mzBMQ5B//0uaQAbqKB6yzgbhXzEDQGNXgrpN96wO1ruVoqcaKop5WoiFw33j+YWQ0E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708707750; c=relaxed/simple; bh=Z+nZGhD3kWUitL/y0fmbHacimRt3c4OrvF3Y7hbB44Q=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=DSz+BPSof0hjAnYUJ99UI1LPF46K/DBEohz4zgqycvYeYIpBRA+4NSZX5586BkaNMce/3p7RJ3H2zvSNpMq7X8vDFPNS75DTCfJe8sEKWG8JdtDOthDzHAvuIf8Zu/QMm35yh7SdBHuSh9nZSzOCZpstDdGQnL/8nSMaJW7d/ro= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-41282f05409so4218765e9.0 for ; Fri, 23 Feb 2024 09:02:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708707748; x=1709312548; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PHwX+ys8bsGvNkEP5nXPK0wN8CBDFL0o5FXjCQ0eE8Q=; b=Xf22Alt6AA2MIiPtAX6KYqbX3a3hPpzluiN9uvfDzQYPgS1JMJ1pBC/GmXxGaDZ1jO gu+ZpMiN2h7TTUTrcc7dRfw1yiuvXOXUCAZY02R2Xyo25JEqTqBy5vhWFLK3ia3/kioh avobXphCZOj0J6f7UYCMK0puZ469EpzJ98zz+U73xCCSb3jV0wz3TbiN+6smmPIhzFvw HxX87/Pug/KYrkV4UjkHWMSurGxW+RGRzpAo5SErPg+IrU0g3kBidTrZHuICdbjG5n2Y ANIRWPMqQgNZicwVRJKHr3m2WkYg1KXEzcIRvlEQDWWWOwofsi6kMwV5oLE2NCsJ9q5Z 8xlw== X-Gm-Message-State: AOJu0YwioXbGnVXWIlzEonp5sVm3cHrE1iHRjBkVadXf2d7G4sDCxs1s yuJ6aSVGuzLJxunGhEh3QozIvR6G99wggM6wI5/7ejjaQyYC2VYT X-Google-Smtp-Source: AGHT+IElQwRaqkx7h8PVrywd8fdJ92ze2WW8xi0AWA6ALMXwp/0neqKjkO2dy5vhP2c9TxdmQU5nbg== X-Received: by 2002:adf:dd8a:0:b0:33d:4bc4:a6a with SMTP id x10-20020adfdd8a000000b0033d4bc40a6amr215307wrl.42.1708707747988; Fri, 23 Feb 2024 09:02:27 -0800 (PST) Received: from ?IPV6:2001:8a0:f918:ab00:ac50:2e85:9ec5:a3f0? ([2001:8a0:f918:ab00:ac50:2e85:9ec5:a3f0]) by smtp.gmail.com with ESMTPSA id z11-20020adfe54b000000b0033da18b05f2sm3377175wrm.32.2024.02.23.09.02.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Feb 2024 09:02:27 -0800 (PST) Message-ID: <48ce5795-8c79-42bb-bcde-b9896166b62d@palves.net> Date: Fri, 23 Feb 2024 17:02:26 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/linux-nat.c: Add "Accessing inferior memory" section Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240221202840.772802-1-pedro@palves.net> <878r3byx4u.fsf@tromey.com> From: Pedro Alves In-Reply-To: <878r3byx4u.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-02-23 16:16, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> This commit adds a new "Accessing inferior memory" comment section to > Pedro> gdb/linux-nat.c that explains why we prefer /proc/pid/mem over > Pedro> alternatives. > > Pedro> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30453 > > Aside from the typo pointed out by Mikhail, this looks good. > Thank you for writing this, this kind of commentary is very valuable. Thank you. I've fixed the typo and merged this.