From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127150 invoked by alias); 31 May 2018 19:40:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127137 invoked by uid 89); 31 May 2018 19:40:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.2 spammy=Hx-languages-length:1086 X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 May 2018 19:40:10 +0000 Received: from ESESSHC012.ericsson.se (Unknown_Domain [153.88.183.54]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 00.15.24558.79F401B5; Thu, 31 May 2018 21:40:07 +0200 (CEST) Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESSHC012.ericsson.se (153.88.183.54) with Microsoft SMTP Server (TLS) id 14.3.382.0; Thu, 31 May 2018 21:39:07 +0200 Received: from ESESBMB501.ericsson.se (153.88.183.168) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Thu, 31 May 2018 21:39:07 +0200 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB501.ericsson.se (153.88.183.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Thu, 31 May 2018 21:39:06 +0200 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [10.0.0.110] (192.222.164.54) by BN7PR15MB2385.namprd15.prod.outlook.com (2603:10b6:406:8c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.820.11; Thu, 31 May 2018 19:39:03 +0000 Subject: Re: [PATCH 8/8] Ptrace support for Aarch64 SVE To: Alan Hayward , CC: References: <20180511105256.27388-1-alan.hayward@arm.com> <20180511105256.27388-9-alan.hayward@arm.com> From: Simon Marchi Message-ID: <48d2a4e3-f89a-203d-fb0b-9d58626f8196@ericsson.com> Date: Thu, 31 May 2018 20:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180511105256.27388-9-alan.hayward@arm.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YTOPR0101CA0035.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b00:15::48) To BN7PR15MB2385.namprd15.prod.outlook.com (2603:10b6:406:8c::23) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:BN7PR15MB2385; X-Microsoft-Exchange-Diagnostics: 1;BN7PR15MB2385;3:yrPYrkw8qpIFMntTgBQtDcZ2eEK81amSTt1BH/9Gl+eLQXLmgP4a9b/uDbNWKimDTuZHcHEugBgOaoSH/oRgOZBr9GWpQxTt9ZtHy2TxoqrKkx0uTEYWqkytT06ZrpxB9fAjr7kVNCyO6c5mV4yzpz1X0eF2iZdLq4+WPJJCqZPw6urEVlOkaMJjuAtDo0I+H6f0DB8R/gCIOfGL4Odz7PManfEaV+bhdcke2ycIDcU7s5RJy1p259m1KB7l58Mz;25:MEKK/SO5Q9qY92T4BPGDZ5Im0OGn/zJCu4n7VzHzhpMTJsWX6C3B/9yaNp110LIFX2iSsQO583Lvt2GCT6u4R9gC5NsEzBwOTUXElKcEnfAUFjrmZNUG045pHs8CvUDwlzYtK3+613J/iis7MIe+B9HhLMEt5JtvlFulW/hof/QjJwHyhYIXfGbMeZ7RHqngmgyIMIZy6nH/vSTjI6AbwSQ5MZnxq6Ep8l3o5LVt8BZsHXwTP8mT8Pw4TjnNg+Ac+DUHXaIc8PBfq5Hu2JJB/LzdT0wCwY2WhYzsA5/c69300CmbNPprWah1C+05Hzgr5qhV60Rwxzakr6cyhQznFQ==;31:yVLLQT5npp7IjxH3/A4WMgpB2BxN+anL1pdI8SkrgB1hKV/ZNn6rMdYbdANtaymgaT/T+IVlbd638e9tvysVTqZjpKWeNGFITobnd9sT/APkc89a3PgGy/+kwAyB91YgLT4Vk8idpyIJYjKwES32TDLbm14J8DGVpMX3sOrXhONxeIXmg2PqJwbkRaKhIDNxTDMZyhlD4fNwqEWu9BsRxn3uljlQM/TV/J8O3qH/DDc= X-MS-TrafficTypeDiagnostic: BN7PR15MB2385: X-Microsoft-Exchange-Diagnostics: 1;BN7PR15MB2385;20:oDecwsMyTf4owN2YPKrRnWn7mfZt2Y6+ASjSuLh0nhvpbQJyIa4Oj5f5Rivye2ZAQxmmADPR8Ysk24EQdkJSqh8gJmolAZ+oukwMFmpym+EvQGzCV2wP18j6lMQFHAcPYmKU1R+E1Ocu8SvV6K+v49xvUMPx0ve++oBJm3zM/XdnBLdJa/VUMNR1PdKFYqnYSHYUtSqaY6Xa930otJCaVDk2GtU/B+qaJesqnLzNSjy9oY63AmW+vET6Jl6/2qntHvOqFTmOjsjSP3a74VnLGLSpA3gwt5NQ89/DoYv58S5bUp7ioD2oAKZaZzz83Oo6R8EE5IiP4j6wuyZCTqL+hNVJjOFMpSB24ggDPmiZGl/IQlAM7zPPGxjZrmk5byVLDebNlQqzcVqF2n45vBx84DnWIzp+XywCPdSYdNBCL4jSv1EgK3XZh89F+DvAkFskGfu+kcP2JzAZRzy+zj3kLmf9M9m/RyuM73Ye+DyDY5pp7VD8VYPEkAxkemS6WdHO;4:Gz2bNl0qCE3SQ3g78f8VpH1l7PTFxynSnCmWjWmP1S/cr+wRZ3BjNLcJ1l6nk5I9CD0d9xN6jCb76kfvN9oRYXjz3Nbfk622/4OiGVZSYEhyABoWa/iUEkNOJSH33GIUVBq7brvvt9b2KVDjxuRc+VXtrK+rDJdjRuLw/+PHUW0OyrToc+0Hws6U1KYR+AQrWbq4cBrWaUo1+G2lXk2jAQMuA0rw5t+5vXJ1GP/sdCNfjdrk/kxBLf9Tq+ovOw7AiAxqh5dn1Kce/lifzW8UZA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231254)(944501410)(52105095)(3002001)(93006095)(93001095)(149027)(150027)(6041310)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(6072148)(201708071742011)(7699016);SRVR:BN7PR15MB2385;BCL:0;PCL:0;RULEID:;SRVR:BN7PR15MB2385; X-Forefront-PRVS: 06891E23FB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(376002)(366004)(346002)(39860400002)(39380400002)(396003)(199004)(189003)(23676004)(31696002)(229853002)(575784001)(86362001)(478600001)(476003)(2616005)(956004)(53936002)(6486002)(8676002)(65826007)(105586002)(106356001)(486006)(81156014)(81166006)(5660300001)(44832011)(36756003)(6666003)(31686004)(305945005)(7736002)(8936002)(316002)(4326008)(186003)(25786009)(16526019)(65806001)(65956001)(53546011)(26005)(47776003)(2906002)(68736007)(16576012)(58126008)(6246003)(77096007)(64126003)(11346002)(3846002)(66066001)(50466002)(6116002)(76176011)(386003)(97736004)(446003)(230700001)(52116002)(2486003)(52146003);DIR:OUT;SFP:1101;SCL:1;SRVR:BN7PR15MB2385;H:[10.0.0.110];FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:3; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjdQUjE1TUIyMzg1OzIzOkdDNjVRZDBKRGdRdmhuV0Rlc296azJhM3Jp?= =?utf-8?B?eGVHaFFiWE05T1RsM1JLRGYybUdEVlJMSXV5aDNKYlNaVFNTVFY1V3lrZWJn?= =?utf-8?B?MUVtU1M3Z1BBcHNZNlp3VjBOYzBRYVAxTVJ1em9aNlR2ZW1hTzhsYmdDSk1T?= =?utf-8?B?WVRDOFNDUmp4eGxyV1hhVHBlK2x5cHdlVWpsRG5NbzRsOEJpb25yblBaZ0tY?= =?utf-8?B?aFJJNWxDemNOSVNmYTBHK3NERFdZdkYzSlJ2NVBhMDFwNGo1S01VQ3h4VkJP?= =?utf-8?B?SC83WlV6bDFLYm1LU1doMi9Mci9OVmRqemZQWmRDTUxQaEhlbkt1TzFweS9I?= =?utf-8?B?UllGazA4N1Z1TWlZSTllWit5WmRWbFloYnhYWW1VRjdGVWhRNUpGeVpObWtQ?= =?utf-8?B?TTkrWjZXUThlanNBMXBmVFpTKzRpUEx0ZGpMU0xxRVFYY216VWlaaXE0eHZI?= =?utf-8?B?ZG5wU2w5QjA4WVNxbmxqZW1HRE83UzBIWUtzMTIwZHpqNTZUbzQ5eDdhZG1l?= =?utf-8?B?Q09CNUI1Z3RWcTU3Z0N5aWJIZnpaR0pINzF5VU1iQzc3MzJ2OWVTRkNIMzNP?= =?utf-8?B?OFRZblQrdkJHbzkvUHdRY2VvTUYyY3BkaFlwTFgyUU9SbEVIeTQwU0Q4UnZn?= =?utf-8?B?bkgxRVNlVXRDeGRZZU15eWhwUk16bFdxeWZ3VGRBOHhGN0gwSjk2eUV2bWh3?= =?utf-8?B?bDhQWW52R1VZVENlRjhBWmw1WGUxTzd6TlpoZWVnWlowRlBCREdOMG1qNkNT?= =?utf-8?B?MEhGNFJ0YUk0b21yUi8vNmRpOCt5M3lob0UvVjY2eXJpR1paTU1XWXVxQllZ?= =?utf-8?B?QzJobjRIdnVqT1huSEhDa1gwVjBEOUlhZFlLUzF4bWhyTTJBYXVIeU5qeGVQ?= =?utf-8?B?Z1JLSmFCOEQ0dms0NjYwTnF1emp3b2hkenhVUnpDZ2ttQmdtdnFQZmxLN1Fz?= =?utf-8?B?cW5FcFM0WFBsVzRlOTdVQ0VzN2MzOFVWYVF4L29jSUhVS0EzbFFXTTc3K05X?= =?utf-8?B?QUxucjE1QUxoV3I0QTNBNVhxQTBRNzdNYVo4TVVNcHFEQUtMVWlrTEtXM01G?= =?utf-8?B?R29XOGFyNDUva0NVbnA0alNHRW9JblJxU0NQdFp1UkYvVmJIVURKMXhJUjRO?= =?utf-8?B?ZUJGZ0RoMlBxR2tZQkJkMjNKdWRtVDlzMld4di92TFJXOU54dHNveDJiMUZP?= =?utf-8?B?clE4YVpkMXRVUU5ENmNtY3l4ZHBHWHhVSHNrZ2xtdko3Uzh3ZnlhUU1rUjRG?= =?utf-8?B?S3lQcGd6L0JrcTloWVZ1SkZtVENrbHVKbFAwT25ZenBIaEJJZCtsM0ljbGpF?= =?utf-8?B?cUtGZklxWEd2SFVxeTJtdzIya0RtNFdWMFBnMHBRbW9reERFSnFLazJweEp1?= =?utf-8?B?NE92ME5yTzcrUUJTanVmb3Q5YVNSQVROUTB1UFNURlZlN1VuakZXMUY4V0RH?= =?utf-8?B?VndqSVdOL1FTdGdOdTdlTlZ4WmIyWFhOMUl2alA5cFU4VTFWYXlGZ293alJo?= =?utf-8?B?Y2FiTGFuNUpWdk5kaElDdEZlNHpKaUErWW1lWmZxRENpRGVLZnM3MkNCRDNF?= =?utf-8?B?djQxS3J3VHFlSVhqVktqcXNxSitiNmJiYXlDODk1ZUM1Z1huN21hVTlDNWtL?= =?utf-8?B?RGw2Y2ZleE1VMERENkhReFU2S1UzdjdWSEJYMEU5b09XSGRSS0FxTzEzQkVT?= =?utf-8?B?RnV4akgvTVFVSHdTOTVLVE0vTTFqNVVTUGJFaktsMGNySDhtOVdRdDFBMlM1?= =?utf-8?B?a2loWVd2SXlUWHdPT0ZwOG9DZ0ZOTUZKOGlzYkh4WnNHRVpiOGFYWkZhdTZR?= =?utf-8?B?RkJJbnJESnRBaGJqTnh5SERReCtZRTdDdVphbytiek5BVFRZTWxIaTN5TkVo?= =?utf-8?B?MzZUb0N0TWlFbDdoLzd1dlU0YlN2MjNsdDhxYWhQUUhyRHBNQkxoRVJ6Q2FJ?= =?utf-8?Q?acHGtsUYMpToLhPJZUlm7ERGe6sUWw=3D?= X-Microsoft-Antispam-Message-Info: 2j8Ne3vwtkoDi4fsYBRqeYXHpOczf/Ob2trX6sTALUTCDWbUabXXdFhv9IUEHamEpnQmHV3qjUDtXK+12PSktig8aXGSk9AomEv6CsmGKd+E5EumhxMo6VQDIJkvN0Gxf5YSUTs8UsTbwIOZK+cSejHd6X0b4gnO6UH6R7cQKbDLQeUZ93QKqoK2w1BqVDxV X-Microsoft-Exchange-Diagnostics: 1;BN7PR15MB2385;6:ichlEJ6tClHYMzFzPyDfkFmWsfQri3atXJLEmCSmQ+qIjE2Ugr8Dfk6UH9HlFp80p0LYZFPX6M005S94bc9dgsFdrImoEBnA80Qx3dOoo7jc8kcDVTDT+1Y01ooUNh+NIOr8Vg35HxVx/s8H2nNZ9sP/40QtxayNNrSxicvJ7uXHgDhRH9AgJ7THNxuo4nc5rS9fvY5G1DSzCaY5oPeYBoK4ZXF+Y/4ujnkOhmpOJ/QxVRZm8R1noV09Xqq4pgtCddZiKxLa+i7S4Y5yBLLYZ49TWcj5nWA97HMKhDuAcDmWuEDazzeI6dfrBmnzf/6E6qGXy07e760ulpwNmH0iC2xGEnOi3adrcQ3JJVl6vlZrpm6z0OvqeX7bc+KMKlvyF3wZ5GZ3Zc1NII3DpvlQ99oWlKp98hyn6l+QV9mXLrz5ynaW8vFrtNX3PyWkiT8cm6ohWB1LfhRV05XwdpocZQ==;5:RqQAEvhRdVvWpIYirz9fSobitPhRrwG+XMA9jXrgY29mZbetrRM0tPcIvxw0EeROEd+tjUJHQFetpIuWTrQ9EtohrscyHzzwGEdqyvnpHC711xy+67SXOoE6m/y5iUSnaFBT0PNjPAmE64+CVUVnOeRA3uIfONm+T4eIOJGSDhY=;24:LoHIx3TlVctPlroF48zfO80q93Pr1kt8OvXAJ/ZpPO47VYvE3WqxmWzAKGRIUSEe5ZnEz5uinEHRlnWWzvqS0ffwIuPsJnHj/ImROdQhmNI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN7PR15MB2385;7:rYi/nzCX5o+wtL0zKQw0MDj9z2es9Xq/yb3f0fGa3HOE2IewFx6srOtKzXyBfY377m3T+9v8t+JEmq5LGtxSoR2R35ITo5ie+UvADV5cmxkdHLk80eLef5FX0gjPisA/AB3JWRDXhlE+0FyBVmChhbuVH3711AKvstiFhVOXO0Y3OZP1iq05+zysgOiHbbPCqxhUDx9ht4axgvxuCvGi6UMyjatKkqwadX2GFvfdzhO9z04P/DcS3Eu7Ow83f3ki X-MS-Office365-Filtering-Correlation-Id: c9bf960f-55a5-41e2-2563-08d5c72e2aae X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2018 19:39:03.3486 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c9bf960f-55a5-41e2-2563-08d5c72e2aae X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR15MB2385 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00870.txt.bz2 On 2018-05-11 06:52 AM, Alan Hayward wrote: > diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c > index 1270b7e0c0..bc570ade6d 100644 > --- a/gdb/aarch64-linux-nat.c > +++ b/gdb/aarch64-linux-nat.c > @@ -388,19 +388,65 @@ store_fpregs_to_thread (const struct regcache *regcache) > } > } > > +/* Fill GDB's register array with the sve register values > + from the current thread. */ > + > +static void > +fetch_sveregs_from_thread (struct regcache *regcache) > +{ > + gdb_byte *base = aarch64_sve_get_sveregs (ptid_get_lwp (inferior_ptid)); > + aarch64_sve_regs_copy_to_regcache (regcache, base); > + xfree (base); > +} > + > +/* Store to the current thread the valid sve register > + values in the GDB's register array. */ > + > +static void > +store_sveregs_to_thread (struct regcache *regcache) > +{ > + gdb_byte *base; > + int ret, tid; > + struct iovec iovec; > + > + tid = ptid_get_lwp (inferior_ptid); I've just noticed these two uses of inferior_ptid. I think we should get the ptid from the regcache instead. Simon