From: Simon Marchi <simon.marchi@polymtl.ca>
To: Lancelot SIX <lsix@lancelotsix.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v4 3/4] gdb: Have setter and getter callbacks for settings
Date: Tue, 5 Oct 2021 15:10:55 -0400 [thread overview]
Message-ID: <4909e2ce-64db-525c-0199-458138c32460@polymtl.ca> (raw)
In-Reply-To: <20210929215011.1489639-4-lsix@lancelotsix.com>
> @@ -241,13 +295,23 @@ struct setting
> gdb_assert (var_type_uses<T> (m_var_type));
> gdb_assert (m_var != nullptr);
>
> - return *static_cast<T const *> (m_var);
> + if (m_var == nullptr)
> + {
> + gdb_assert (m_getter != nullptr);
> + auto getter = reinterpret_cast<setting_getter_ftype<T>> (m_getter);
> + return getter ();
> + }
> + else
> + return *static_cast<T *> (m_var);
While pulling these upstream changes to the ROCm GDB port, I found that
we forgot to remove the `gdb_assert (m_var != nullptr)` above.
I can fix that when I send a patch that actually uses the
getters/setters (which would trigger the assert).
Simon
next prev parent reply other threads:[~2021-10-05 19:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 21:50 [PATCH v4 0/4] Refactor cmd_list_element.var Lancelot SIX
2021-09-29 21:50 ` [PATCH v4 1/4] gdb: Introduce setting construct within cmd_list_element Lancelot SIX
2021-09-30 12:12 ` Simon Marchi
2021-09-30 12:30 ` Simon Marchi
2021-09-30 23:15 ` Lancelot SIX
2021-10-01 1:16 ` Simon Marchi
2021-09-30 12:39 ` Simon Marchi
2021-09-29 21:50 ` [PATCH v4 2/4] gdb: make string-like set show commands use std::string variable Lancelot SIX
2021-09-29 21:50 ` [PATCH v4 3/4] gdb: Have setter and getter callbacks for settings Lancelot SIX
2021-09-30 12:42 ` Simon Marchi
2021-10-05 19:10 ` Simon Marchi [this message]
2021-10-05 20:27 ` Lancelot SIX
2021-10-05 20:39 ` Simon Marchi
2021-10-05 22:21 ` Lancelot SIX
2021-09-29 21:50 ` [PATCH v4 4/4] gdb: Setting setter return a bool to tell if the value changed Lancelot SIX
2021-09-30 12:43 ` Simon Marchi
2021-09-30 12:44 ` [PATCH v4 0/4] Refactor cmd_list_element.var Simon Marchi
2021-10-03 19:22 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4909e2ce-64db-525c-0199-458138c32460@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).