From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simon.marchi@polymtl.ca>
Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11])
 by sourceware.org (Postfix) with ESMTPS id E16BE385C404
 for <gdb-patches@sourceware.org>; Tue,  5 Oct 2021 19:12:04 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E16BE385C404
Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0)
 by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 195JAuPa017478
 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); 
 Tue, 5 Oct 2021 15:11:01 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 195JAuPa017478
Received: from [172.16.0.95] (192-222-180-24.qc.cable.ebox.net
 [192.222.180.24])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id F2D6B1E813;
 Tue,  5 Oct 2021 15:10:55 -0400 (EDT)
Subject: Re: [PATCH v4 3/4] gdb: Have setter and getter callbacks for settings
To: Lancelot SIX <lsix@lancelotsix.com>, gdb-patches@sourceware.org
References: <20210929215011.1489639-1-lsix@lancelotsix.com>
 <20210929215011.1489639-4-lsix@lancelotsix.com>
From: Simon Marchi <simon.marchi@polymtl.ca>
Message-ID: <4909e2ce-64db-525c-0199-458138c32460@polymtl.ca>
Date: Tue, 5 Oct 2021 15:10:55 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <20210929215011.1489639-4-lsix@lancelotsix.com>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 5 Oct 2021 19:10:56 +0000
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3,
 RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Oct 2021 19:12:06 -0000

> @@ -241,13 +295,23 @@ struct setting
>      gdb_assert (var_type_uses<T> (m_var_type));
>      gdb_assert (m_var != nullptr);
>
> -    return *static_cast<T const *> (m_var);
> +    if (m_var == nullptr)
> +      {
> +	gdb_assert (m_getter != nullptr);
> +	auto getter = reinterpret_cast<setting_getter_ftype<T>> (m_getter);
> +	return getter ();
> +      }
> +    else
> +      return *static_cast<T *> (m_var);

While pulling these upstream changes to the ROCm GDB port, I found that
we forgot to remove the `gdb_assert (m_var != nullptr)` above.

I can fix that when I send a patch that actually uses the
getters/setters (which would trigger the assert).

Simon