Re: [PATCH 2/2] Use subclasses of windows_process_info

[Jon Turney <jon.turney@dronecode.org.uk>]

On 07/04/2022 20:56, Tom Tromey via Gdb-patches wrote:
> This changes windows_process_info to use virtual methods for its
> callbacks, and then changes the two clients of this code to subclass
> this class to implement the methods.
> 
> I considered using CRTP here, but that would require making the new
> structures visible to the compilation of of nat/windows-nat.c.  This
> seemed like a bit of a pain, so I didn't do it.
> 
> This change then lets us change all the per-inferior globals to be
> members of the new subclass.  Note that there can still only be a
> single inferior -- currently there's a single global of the new type.
> This is just another step toward possibly implementing multi-inferior
> for Windows.
> 
> It's possible this could be cleaned up further... ideally I'd like to
> move more of the data into the base class.  However, because gdb
> supports Cygwin and gdbserver dose not, and because I don't have a way
> to build or test Cygwin, larger refactorings are difficult.

Understandably, without that capability, this change breaks building on 
Cygwin. I've sent a patch to fix that.

If you explain what the difficulties are with building for and testing 
on Cygwin are, I may be able help you.