From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by sourceware.org (Postfix) with ESMTPS id 64A523858D39 for ; Mon, 27 Feb 2023 14:53:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 64A523858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f46.google.com with SMTP id bg16-20020a05600c3c9000b003eb34e21bdfso3932886wmb.0 for ; Mon, 27 Feb 2023 06:53:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yBHLS8SsZazLPJke6BcYSdfLSJk/gdKksE4UNUMM0TY=; b=LDOypjLnTQ8rIrmRuKaLHSO3Zn/E+R0wv8+lLuM1o9icH6p4vP5tMDteVyH+yA55Xy EpUX40pxkZieBD0Slfpz2dCeUkY+VE5YUnjEZqL5KoF11lkkrZezXz+0Lp7jgk9JFtLU LhNQVi19SSpj4UMp/jhosoQt4QwjYvVWvTBTvFstiyu/m9y172gjVTObx1dKNK58Q+GQ lV6Qlo83XFROwBrjlBcGLVNLMd7zl7FJU6goFbc1UqUOMeQfTYRe9lrTtpo+QTJ6CLkG 8jlUYHvzYr/iUj0ZHz/e9AKzS7ybb+19EBjDfZ1blMvv2O2Hnk8W4GINBFpxJPCBu+Z3 lMXw== X-Gm-Message-State: AO0yUKW/2gMFe2tXICZvMnz3GYGw+GCbvZHNrUCuT52U5VXuPoUFZMAC N3m4zkxXYWKPAzcI4PDdy3RH/izGj5U/nw== X-Google-Smtp-Source: AK7set/GN70h9Dgwt8kvw9ZMSxrWuOlH61D2zzplTrTdHCmnupd2+q8YFoaHHWZzh7Zlc6UWMIdulg== X-Received: by 2002:a05:600c:44d2:b0:3df:f7f1:4faf with SMTP id f18-20020a05600c44d200b003dff7f14fafmr18395069wmo.34.1677509630871; Mon, 27 Feb 2023 06:53:50 -0800 (PST) Received: from ?IPv6:2001:8a0:f92b:9e00::1fe? ([2001:8a0:f92b:9e00::1fe]) by smtp.gmail.com with ESMTPSA id t14-20020adfe44e000000b002c5503a8d21sm7451349wrm.70.2023.02.27.06.53.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Feb 2023 06:53:50 -0800 (PST) Subject: Re: [PATCH 0/2] Autogenerate gdb/syscalls/linux-defaults.xml.in (syscall groups) from strace sources To: Tom de Vries , gdb-patches@sourceware.org References: <20230224232650.4031472-1-pedro@palves.net> From: Pedro Alves Message-ID: <491b0be5-578d-96f8-5cc7-b5606d179d78@palves.net> Date: Mon, 27 Feb 2023 14:53:52 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-02-25 9:31 a.m., Tom de Vries wrote: > On 2/25/23 00:26, Pedro Alves wrote: >> While working on the step-over-thread-clone/exit series, I noticed >> that one of the new tests was failing.  The test does "catch syscall >> clone", and expects that pthread_create calls clone.  Turns out that >> on the glibc shipped with Ubuntu 22.04, pthread_create calls clone3, >> not clone.  To make the test cope with that, I thought of switching it >> to "catch syscall group:process".  Surprisingly, that catches "clone", >> but not "clone3". >> >> This series fixes that, by adding a script that extracts the syscall >> group info out the strace sources. >> > > If I understand correctly, this is orthogonal to update-linux-from-src.sh ? Right. This generates the linux-defaults.xml.in file, which is not generated by update-linux-from-src.sh. The groups info is not found in the kernel. linux-defaults.xml.in maps between syscall names and groups. The arch xml.in files map syscall number to name. The makefile combines each arch xml.in with linux-defaults.xml.in generating a final .xml file with maps the number to name, and to groups. > [ FWIW, i've just ran update-linux-from-src.sh with linux kernel sources v6.2, and there where no changes. ] Great, I was wondering whether we needed to re-run that with a recent kernel. Thanks for taking care of it. Pedro Alves