From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23157 invoked by alias); 31 Aug 2016 10:29:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23131 invoked by uid 89); 31 Aug 2016 10:29:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1091 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 Aug 2016 10:29:46 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0058D86647 for ; Wed, 31 Aug 2016 10:29:44 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7VAThCP003968; Wed, 31 Aug 2016 06:29:43 -0400 Subject: Re: [PATCH 2/2] Share target_wait prototype between GDB and gdbserver To: Sergio Durigan Junior , GDB Patches References: <1472443911-29056-1-git-send-email-sergiodj@redhat.com> <1472443911-29056-3-git-send-email-sergiodj@redhat.com> From: Pedro Alves Message-ID: <49223e65-a30b-7e0e-d545-35799d73b6f7@redhat.com> Date: Wed, 31 Aug 2016 10:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1472443911-29056-3-git-send-email-sergiodj@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-08/txt/msg00306.txt.bz2 On 08/29/2016 05:11 AM, Sergio Durigan Junior wrote: > --- a/gdb/target.h > +++ b/gdb/target.h > @@ -1341,18 +1341,6 @@ extern void target_disconnect (const char *, int); > > extern void target_resume (ptid_t ptid, int step, enum gdb_signal signal); > > -/* Wait for process pid to do something. PTID = -1 to wait for any > - pid to do something. Return pid of child, or -1 in case of error; > - store status through argument pointer STATUS. Note that it is > - _NOT_ OK to throw_exception() out of target_wait() without popping > - the debugging target from the stack; GDB isn't prepared to get back > - to the prompt with a debugging target but without the frame cache, > - stop_pc, etc., set up. OPTIONS is a bitwise OR of TARGET_W* > - options. */ > - > -extern ptid_t target_wait (ptid_t ptid, struct target_waitstatus *status, > - int options); > - Please leave a breadcrumb comment here, like was done for target_read_memory, for example: /* For target_read_memory see target/target.h. */ Thanks, Pedro Alves