From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-157556-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 64420 invoked by alias); 17 Jul 2019 12:37:44 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 64373 invoked by uid 89); 17 Jul 2019 12:37:44 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=sal, HX-Languages-Length:402
X-HELO: mail-wr1-f68.google.com
Received: from mail-wr1-f68.google.com (HELO mail-wr1-f68.google.com) (209.85.221.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Jul 2019 12:37:43 +0000
Received: by mail-wr1-f68.google.com with SMTP id n4so24690105wrs.3        for <gdb-patches@sourceware.org>; Wed, 17 Jul 2019 05:37:42 -0700 (PDT)
Return-Path: <palves@redhat.com>
Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b])        by smtp.gmail.com with ESMTPSA id r5sm25889773wmh.35.2019.07.17.05.37.40        (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128);        Wed, 17 Jul 2019 05:37:40 -0700 (PDT)
Subject: Re: [PATCH 61/61] Remove unnecessary "return"s
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20190704170311.15982-1-tom@tromey.com> <20190704170311.15982-62-tom@tromey.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <4925a215-2cf0-8d81-e4fc-321ed9f02a28@redhat.com>
Date: Wed, 17 Jul 2019 12:37:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20190704170311.15982-62-tom@tromey.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-07/txt/msg00384.txt.bz2

On 7/4/19 6:03 PM, Tom Tromey wrote:
> @@ -293,12 +291,11 @@ tui_show_disassem_and_update_source (struct gdbarch *gdbarch,
>  	{
>  	  set_current_source_symtab_and_line (sal);
>  	  tui_update_locator_fullname (symtab_to_fullname (sal.symtab));
> +

Odd empty line.

>  	}
>        else
>  	tui_update_locator_fullname ("?");
>      }
> -
> -  return;
>  }
>  

Thanks,
Pedro Alves