From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2085.outbound.protection.outlook.com [40.107.21.85]) by sourceware.org (Postfix) with ESMTPS id ED4AC385842C for ; Mon, 11 Mar 2024 15:10:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED4AC385842C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ED4AC385842C Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.21.85 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1710169839; cv=pass; b=EE4+v+MIHThHGnDBqneisIXuOI6DN1h/jqyex5w7DWIY5JjL8UcDwJmSgcNcMSX/2sRhrR3Z6ksjfpiA5Op/ExT+XFA+to3CedXotlDThiJP5Iw2uLbmff3850YrohNxZpidvpcJ40Hw4XUaZ8Bs9QkWqM7C49P8gWLMjQpcMtg= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1710169839; c=relaxed/simple; bh=ZYZO3lCNaO9JcOFGfNtQw9wPa0972P2kVZXZnp/7iVc=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=fZRHOpWpZy6aLLA8x5lED6lSWAAwdJFtQ2lM2vhJP/9+DXy3G6PNmZQyBKhzdbjPkKmgrudyZ8nulARN/OBAyjZ0hbz7MRsOk0d8lX0qPeOGXtPPxuuJkj7zZQL13CzFcoWw3CXCqOGZEcsGski8xFM2kaZhIE63HUkCrc6EKvU= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=m6hr1/0uemExoOpvlAhP51yi/fcoMA+TAlqNZmOkRkkgg/KT/zOJvcZcYU9nAQntTfOqwwBjGfLMkF3tPeoJOUhGX/0uAfZ4A/6S8zNfiXPH00wQkqwnT9N5wBDDpU/UXZW/dRyVGsu4rIM4F8RnnULIEYl8TZ3PCRgkd31gbPjDyjUWocMeW9NUpWDT34jJjMcKlMzGOpika/yfHUrId3VbCZgqE6UU+vxo6DXHIYD4YP7aTY4WKs48Qh0CfKy+l9z4vAkZvUQDnD0vGvgFscNcbm0vb80APmUWwRMcq/fcKSEIO8DpTsQOfsse90rbEtduMCGlBMmBM7EL6K6dTQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gu8ky3/LV7c9Lkm7LFzVpE52sa8lZISOHaQATy7OCnI=; b=epH5VmxtIgdb6xvCFVbOcKrjbK4JHM1jDatgS73CRyAhnWojL+Ey4uc+2L82tmJ6b9kpJB3iT0VkxXXgd0G/fjaTK34nyDiAMgQS054GvfLJVj4+jmtUek8G/tvGy7BrgPDHwy2YKHdWk1+mTncn8+haW4ILEf3hd+WsD01dpm1taZwyeC1NfYs5XZ9G/yfBRLGPbk/P8qV2eg9ZNBUaDlfqZWe5LzesDHk/y8MTeI0UKTs2Oj3jQcNaL89opJ8zVMmZCAVIsJTvoPXP+TRabtzaw/gVMowqag9TZ6CdVVttIbs6x1RpiJUGYbOb5w+q/0ZqBg06IDkvekTMXwnwQg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gu8ky3/LV7c9Lkm7LFzVpE52sa8lZISOHaQATy7OCnI=; b=vZso7xU8oxlfURkU59yfMvL0vuOO0bwoAqyX0jzMg8tD/rbcyuRYPBXfBiWAWCNh588sn1se9UgtJYjLOvYPje/TG9kvhta0yhNj5RnIqelVkJYowpuSnb2uwhqP5XyhaKwBxmammxrypCo52hoHn7FrhnZ8xxKcLKYctpLEQn0= Received: from AM6P195CA0103.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::44) by GVXPR08MB7751.eurprd08.prod.outlook.com (2603:10a6:150:7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35; Mon, 11 Mar 2024 15:10:32 +0000 Received: from AM2PEPF0001C711.eurprd05.prod.outlook.com (2603:10a6:209:86:cafe::7a) by AM6P195CA0103.outlook.office365.com (2603:10a6:209:86::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.34 via Frontend Transport; Mon, 11 Mar 2024 15:10:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM2PEPF0001C711.mail.protection.outlook.com (10.167.16.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.12 via Frontend Transport; Mon, 11 Mar 2024 15:10:32 +0000 Received: ("Tessian outbound ca5b6496b02a:v276"); Mon, 11 Mar 2024 15:10:32 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8b8d2ac73756251b X-CR-MTA-TID: 64aa7808 Received: from e45086f04f20.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6D93091B-2DC8-47E9-A3C9-61CCABAB2E99.1; Mon, 11 Mar 2024 15:10:25 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e45086f04f20.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 11 Mar 2024 15:10:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O7P4DrKFOl8oPgNQ99NLDh5cWjfKkCemz+f2CjOuzZGVpaZihrKUTMeNwawhCqGGegv8IgQ9222pPFr7UbYraYl4hncdORilbQiqpw5NBFOms9r4S4wnY78odPVT3q9wanQ64fg6obJd4DiqxMWmUr5etjkkqBDeZnMiUfuCbed8bgLnhs9OTcjCaDfWSgQWeqKZX3pCgGpiafEntXUbIL5C4Dm7kxodefNHwnXj6ZmYDMptPJqD/xq4iyEtzUGkoE/eeQ1Y9KRpXoXvfKe1KmNnVNNfSi3IlxD+OsVdowD5lDbAZNtwnPLlpaR97uzB8yZwBA6cL9/gwcB2SeJ8qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gu8ky3/LV7c9Lkm7LFzVpE52sa8lZISOHaQATy7OCnI=; b=fxs5UgJ5xk8m19WXDUIpIN8f227YwFKphkz4aQZvOt59DRG+KEQE8bhn4KwBFDyYKeikqUuGxiW4/cVnfuV8sysccWsuLatBZwu9DN3KMa7oOxMpfhNpm2J2p+8G08DKC0mUKlPMnhxIXl3n9oGE/cEMCnyCY9jTN/iVUlYLD/kWfyVRDDekzFBIRc8EGSCV4ueBGrJ5XLf7cmWh+GK/CuvX50mnZ+PVWCD3HV/eOsQXf8xBr4uj4oyBwzLYLOq0peqK5DPfBvhGFwTI2GaCC9rAQ8Vr+DWjPgLlhdTd/fbUEmMUsX4cnoIlIvxXL7n+9N9eTSEGcQMc6wxH8zPMXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gu8ky3/LV7c9Lkm7LFzVpE52sa8lZISOHaQATy7OCnI=; b=vZso7xU8oxlfURkU59yfMvL0vuOO0bwoAqyX0jzMg8tD/rbcyuRYPBXfBiWAWCNh588sn1se9UgtJYjLOvYPje/TG9kvhta0yhNj5RnIqelVkJYowpuSnb2uwhqP5XyhaKwBxmammxrypCo52hoHn7FrhnZ8xxKcLKYctpLEQn0= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by PAXPR08MB6639.eurprd08.prod.outlook.com (2603:10a6:102:154::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.35; Mon, 11 Mar 2024 15:10:22 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed%5]) with mapi id 15.20.7362.031; Mon, 11 Mar 2024 15:10:22 +0000 Message-ID: <49325cdf-f64c-404d-9b7a-54a820b00ca4@arm.com> Date: Mon, 11 Mar 2024 15:10:19 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] Modernize frame unwinders and add disable feature Content-Language: en-US To: Guinevere Larsen , gdb-patches@sourceware.org References: <20240306125135.766567-1-blarsen@redhat.com> <47e1bce0-1f4f-4ac4-b101-a2496a51cbe8@arm.com> <2702cb98-2bc0-40fb-a871-a10aa1aeb0f7@redhat.com> From: Luis Machado In-Reply-To: <2702cb98-2bc0-40fb-a871-a10aa1aeb0f7@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0237.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:315::20) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|PAXPR08MB6639:EE_|AM2PEPF0001C711:EE_|GVXPR08MB7751:EE_ X-MS-Office365-Filtering-Correlation-Id: fa6722f9-283d-4edb-adc9-08dc41dd655c x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JTxqZZ82ktOe9barZ74ivp5CM91grSikRK53Wb/blDed281kr30tz3g757xZOZ14o6R9YYpSRWrJZa0tB3ce5OOpULJ/rfFvF3XGryOfcgKe5kEHbClmbvm2c0eID+kj998Aqr96XLjAIXWAoTkwM4Jp/vsBPnFsth/Nvg/SuW2lruhrca2fEDhINcSRlkh8k8VbGALmR09DIaDxWjUsrGDXCjGw1MHK5jAhxIrJsDosplJACgjwgJetzMDOlnUyqRzK5oMcJytJmR/mC6khCQndYrYpvPHl0UU4oCWf+nQ/d3YTCRBnhvqFmdvkWsnytSEy4+PYDIB7ki9BKVQhclGCdvSwUBNU7GbBI0zz/Xlsk6ADD4nAuA4OG9KA285cJj3Lo0kZ9nSRTtcraWIYErmFFveWQb/rdjWSXukKQIjb54+/aX6rfD6OI3TboeoKBYYLRPgxHf/UJ26YGp+2SiJBVdLlK5Hcjgp1a0XNL1UUmkr4DN5HTnscBtUpkR1qs1c1lN5m/5yL3qWQJEn4zt0GEGLYp5DUla5D/5qcAF7neatBgSEy66nTeNVxAUI/BfvIohHhJdQNX3wgysCGoUaQD8q+asyoIL6sVkLzc1xz2Nw4EwMzldB5rZDZogfIHq+oL+myG5ZaPJ/DYOz7F7sle2jt6s4Ba1GNEAhFrCg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6639 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM2PEPF0001C711.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3cf35272-1af5-4fc7-2137-08dc41dd5f68 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xha95KeR3MNzjEi9d95k6S46U1F5lkzyMBExAWwc/0q4/hTs8ReyWESU4f+p4+gC5uXSJXMWqVBPvBiT4zQfpZBxwOr79a8IUqXMajsRbMiJFeZoB7/BETgwsvL5wp/KGiQhQQpevwxaxFtJmVQeVFxQa/ThVmyzTxjYtszJkuxbGnkdN8rL4btrGznhHpTvLuMLdIwPZnq0UJ3TT6JowZ0Q4xDXltR5Jxp713+BOePCSCGzGDj5OpCxQnt8wgub5FMWBFAn0FJScxMn4dKjNf2nyxLlKRtpqwHu5kWO+7YeQd+4HfEVdyuArVPhbWbPP7nWTxzlBHkWHKeJd+oRvZrOC5v1QCpZrJ5o2XoWBMU75SD7pRQdAgFMtbDeS7A+ju+MXcts2z+nT25pevqtIv0AcuS8CTcml6NleZsThaamSkz1LLV0Qx08Xt23yfKIrXWPz8d8APaZsvGe+cvTORNoNHbXKP4Btd07sP+oi8x5NHvHQ6t+BxGFHxyhkXWC4Baq9b0VvOOOpTkDoQd0w97TQjGgLP4RatVlTSOTcm/8AwtKO5RLyBWSACCopZsE/XDDet+MxZjNndQEdO4jRQudd/pGijlFK/ZZmGD/U4m/3abMWOq0Tj/fJ118PgLMDEy+Bu9O7rJDm3PUb0NTWkb9+ALNE8zXpbgKERs+k3D2Jm8BJtWwn+HXVO7pPw5rywogNRrd6xd3pEIa1AgJftgS4vyK5hHeUTOSRZAN/xaXdyIYx3N2pl9++jCGdPAw X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(82310400014)(36860700004)(1800799015)(376005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 15:10:32.3449 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fa6722f9-283d-4edb-adc9-08dc41dd655c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM2PEPF0001C711.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7751 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,WEIRD_PORT autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/11/24 15:00, Guinevere Larsen wrote: > On 11/03/2024 15:56, Luis Machado wrote: >> Hi, >> >> On 3/6/24 12:51, Guinevere Larsen wrote: >>> This patch series started with me trying to make it easier to test GDB's >>> ability to unwind using CFI data, to improve a previous patch I sent to >>> the list. However, once I finished these changes, I realized there was >>> an unrelated bug I should fix before proposing the CFI test. Since these >>> changes are significant enough already, and I think would be interesting >>> on their own, I figured I shoudl submit this patch series as is right >>> now while I figure out the other bug. >>> >>> The first patch is just a minor change, storing frame unwinders in a >>> vector instead of through an unwinder table accessible using the >>> registry system. This isn't required (like I originally thought it was), >>> but it does make the whole system more readable in my opinion. >>> >>> Patch 3 has the real meat of the modernization, making GDB use >>> polymorphism to handle frame unwinders. This is slightly slower than >>> using function pointers, but much more readable in my opinion. >>> >>> As for the unwinder classes, they were chosen somewhat arbitrarily, >>> mostly based on where I found an unwinder and its name. I almost expect >>> some unwinders to be mis-categorized, but that should be easy to fix. >>> >>> The changes up to patch 3 have been tested with a try-branch, no >>> regressions as far as I could see. >>> >>> Guinevere Larsen (4): >>>    gdb: make gdbarch store a vector of frame unwinders >>>    gdb: add "unwinder class" to frame unwinders >>>    gdb: Migrate frame unwinders to use C++ classes >>>    GDB: introduce ability to disable frame unwinders >> I haven't gone through the series in detail, but I thought I'd give it a try on one of the >> aarch64 machines I have access to. I didn't look particularly healthy: >> >> >> # of unexpected core files      47 >> # of expected passes            116521 >> # of unexpected failures        581 >> # of expected failures          77 >> # of known failures             116 >> # of untested testcases         128 >> # of unresolved testcases       1102 >> # of unsupported tests          458 >> # of duplicate test names       10 >> >> I see a number of internal errors going on. Mostly like these: >> >>          ../../../repos/binutils-gdb/gdbsupport/errors.cc:58 >> 0xaaaad27e7877 check_ptrace_stopped_lwp_gone >>          ../../../repos/binutils-gdb/gdb/linux-nat.c:1634 >> 0xaaaad27e7877 check_ptrace_stopped_lwp_gone >>          ../../../repos/binutils-gdb/gdb/linux-nat.c:1630 >> 0xaaaad2ae0fa3 linux_resume_one_lwp >> > Oh no! Linaro CI had showed something was wrong, but I wasn't able to grab an aarch64 machine to test yet. I'll check it out when I can, thanks for narrowing it down for me > You're welcome. Do let me know if you can't easily find an aarch64 machine to try things on, and I can provide more info and take a deeper look.