From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=mC3W=4K=gmail.com=alves.ped@sourceware.org>
Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41])
	by sourceware.org (Postfix) with ESMTPS id 32E9F384E21B
	for <gdb-patches@sourceware.org>; Mon, 12 Dec 2022 20:15:59 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 32E9F384E21B
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-wr1-f41.google.com with SMTP id f18so13391311wrj.5
        for <gdb-patches@sourceware.org>; Mon, 12 Dec 2022 12:15:59 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=content-transfer-encoding:content-language:in-reply-to:mime-version
         :user-agent:date:message-id:references:to:subject:from
         :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
        bh=0rqF/70pX3vL8ltOniuaI9xwkKtx3B7E4E12jidp8EA=;
        b=0YK8mQffqdhILSteiFHWOpkQMH/Y5MlfYNVjR69s0gZ1Lub3zDs5by15nRTW5sV5Jc
         TvFxqo8CWVjwFaGPSuGJnTkZ4F2CmoQxpZ+wrs8fc99VBhBtkLiGXgFkjdFX0ZkwizSV
         lOMv5ULoDZ+6iG3vyp/53MLhMVEEzVoPDV4W0TTTeiygb048HfD3IL1l8PfKdZFRkGEV
         jtdLMyoVp5o3NFpFsbQWipNJOwF5cD6uS8H3SoG3BAGnjviyjKIQ55XfcqspriAcyNuR
         0yAEKHPA63ffToJGu4Yx1E0p6Xh5J5uLhFaSyFEBLJdTJS1z3AfsI5Nr7QTl3VJPYKns
         Zs9A==
X-Gm-Message-State: ANoB5pkRM0MqCZ0XMifZGcHHc4/oNUjrwPVpwhRZfJxxYVKAB9PwQVaY
	bb+PE4GwZiO29rcq3KuLQtbb/oKsOlqKUw==
X-Google-Smtp-Source: AA0mqf5KRzHE2sFFKvMwpC0mqtUJTdUUF0mRxZKxiBxaCPWJ7o8ZV9PNs6pAKcubtcpxqNtR64wMrA==
X-Received: by 2002:adf:e410:0:b0:242:32d7:8605 with SMTP id g16-20020adfe410000000b0024232d78605mr12235798wrm.47.1670876158025;
        Mon, 12 Dec 2022 12:15:58 -0800 (PST)
Received: from ?IPv6:2001:8a0:f912:6700:afd9:8b6d:223f:6170? ([2001:8a0:f912:6700:afd9:8b6d:223f:6170])
        by smtp.gmail.com with ESMTPSA id g10-20020a056000118a00b002426d0a4048sm9747822wrx.49.2022.12.12.12.15.57
        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
        Mon, 12 Dec 2022 12:15:57 -0800 (PST)
From: Pedro Alves <pedro@palves.net>
Subject: Re: [PATCH v2 08/29] Thread options & clone events (native Linux)
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
References: <20220713222433.374898-1-pedro@palves.net>
 <20220713222433.374898-9-pedro@palves.net>
 <32c2cd35-9303-2a3d-64f2-c4106bfdf6e2@simark.ca>
Message-ID: <4961ada7-c70c-74d8-a787-ef2c5c34e4fb@palves.net>
Date: Mon, 12 Dec 2022 20:16:02 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <32c2cd35-9303-2a3d-64f2-c4106bfdf6e2@simark.ca>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On 2022-07-21 1:38 p.m., Simon Marchi wrote:
> 
> 
> On 2022-07-13 18:24, Pedro Alves wrote:
>> This commit teaches the native Linux target about the GDB_TO_CLONE
>> thread option.  It's actually simpler to just continue reporting all
>> clone events unconditionally to the core.  There's never any harm in
>> reporting a clone event when the option is disabled.  All we need to
>> do report support for the option, otherwise GDB falls back to use
> 
> Seems like you are missing "is to" before "report".
> 
> Otherwise LGTM.

Thanks, fixed.