From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 49C453858439 for ; Mon, 11 Jul 2022 15:11:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 49C453858439 Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26BEEvbS024542 for ; Mon, 11 Jul 2022 15:11:51 GMT Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3h8nf79rdp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 11 Jul 2022 15:11:51 +0000 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 26BF4tEr024533 for ; Mon, 11 Jul 2022 15:11:50 GMT Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by ppma02dal.us.ibm.com with ESMTP id 3h71a9m1me-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 11 Jul 2022 15:11:50 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 26BFBnfA9765564 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Jul 2022 15:11:49 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 460B66A04D; Mon, 11 Jul 2022 15:11:49 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EEA066A047; Mon, 11 Jul 2022 15:11:48 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.211.68.56]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP; Mon, 11 Jul 2022 15:11:48 +0000 (GMT) Message-ID: <497e9fd7b6e01f1f4fb763a8c055d316aba2ae65.camel@us.ibm.com> Subject: Re: [PING 3] [PATCH] Fix for gdb.base/stap-probe.c From: Carl Love To: gdb-patches@sourceware.org, will schmidt , Ulrich Weigand , cel@us.ibm.com Date: Mon, 11 Jul 2022 08:11:48 -0700 In-Reply-To: <39ca01e864cfeb37c2b84252bd84529142d4703a.camel@us.ibm.com> References: <39ca01e864cfeb37c2b84252bd84529142d4703a.camel@us.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: JSUGNMxTFvrsS9WBZXfIZfteRhgXLV0r X-Proofpoint-GUID: JSUGNMxTFvrsS9WBZXfIZfteRhgXLV0r Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-11_19,2022-07-08_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 clxscore=1015 mlxscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 impostorscore=0 suspectscore=0 spamscore=0 priorityscore=1501 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207110064 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2022 15:11:54 -0000 On Thu, 2022-06-30 at 08:14 -0700, Carl Love wrote: > On Wed, 2022-06-22 at 08:11 -0700, Carl Love wrote: > > Ping? > > > > On Tue, 2022-06-14 at 16:54 -0700, Carl Love wrote: > > > GDB maintainers: > > > > > > The gdb.base/stap-probe.exp test fails on Power 10 with a compile > > > error > > > due to a missing include file. The include file provides the > > > definition for ATTRIBUTE_NOCLONE. The following patch add the > > > missing > > > include file. > > > > > > The test now runs on Power 10 with 98 expected passes and 4 > > > unsupported > > > tests. > > > > > > Please let me know if this patch is acceptable for mainline. > > > > > > Carl Love > > > > > > ----------------------------------------------------------------- > > > ---- > > > Fix for gdb.base/stap-probe.c > > > > > > On PowePC, the test fails on a compile error: > > > > > > /../binutils-gdb-current/gdb/testsuite/gdb.base/stap- > > > probe.c:107:1: > > > error: expected '=', ',', ';', > > > 'asm' or 'attribute' before 'use_xmm_reg' > > > 107 | use_xmm_reg (int val) > > > | ^~~~~~~~~~~ > > > > > > Where the source code for stap-probe.c is: > > > > > > ... > > > static const char * __attribute__((noinline)) ATTRIBUTE_NOCLONE > > > use_xmm_reg (int val) <-- line 107 > > > { > > > ... > > > > > > The issue is the ATTRIBUTE_NOCLONE is not defined as an attribute > > > as > > > expected. The #define for ATTRIBUTE_NOCLONE can be found in > > > ../lib/attributes.h. > > > > > > This patch adds the missing include statement for the definition > > > of > > > ATTRIBUTE_NOCLONE. > > > > > > The patch has been tested and verified on a Power10 system. > > > --- > > > gdb/testsuite/gdb.base/stap-probe.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/gdb/testsuite/gdb.base/stap-probe.c > > > b/gdb/testsuite/gdb.base/stap-probe.c > > > index d1482c35caf..527f7e187eb 100644 > > > --- a/gdb/testsuite/gdb.base/stap-probe.c > > > +++ b/gdb/testsuite/gdb.base/stap-probe.c > > > @@ -15,6 +15,8 @@ > > > You should have received a copy of the GNU General Public > > > License > > > along with this program. If not, see < > > > http://www.gnu.org/licenses/>. */ > > > > > > +#include "../lib/attributes.h" > > > + > > > #if USE_SEMAPHORES > > > > > > #define _SDT_HAS_SEMAPHORES