From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 95C5B3858D38 for ; Wed, 21 Feb 2024 17:36:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 95C5B3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 95C5B3858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708536987; cv=none; b=OM0QjNdwshhyGnvpezX64xpkqBk73Ih6Iw8g3ZG6B9DkhhNTnqnhpG24zFZqhljygd5kcT7Ztm9Qs18I84sTN8Y+hOBkjQu81CQ//E9cs4NF8lUdD2gHy1QLAIwxh2cBd9aJvRPwRXm4cPHLpUVn59/2BWaiF1CYEgq6YUVAwjA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708536987; c=relaxed/simple; bh=Eb4kX0D4MU2O5nisQdvN2ms1Cz/nJNp/oSVkb949wuk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=wcE5LHVYbzcEXgmmiLmMCM8HfTgZHSpajlzRKmfUqi+7HByy4ms9t/DK/8tN0I76xEPvQf5OdnrI5YgJsWNU/mz9hv08qNgNF/9IM5dhAFyAnjRDM2yeHYvD9DTGWSAc/NkhDw1gtf+HfGUKb9KQOHA4I0P4UyCDVRTtqjdBLkQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1708536986; bh=Eb4kX0D4MU2O5nisQdvN2ms1Cz/nJNp/oSVkb949wuk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=a2WH8Ru+s3joLIx+8TfvAt8+2SPDhKq0849nlkMLrB106fYi3SmntvBBWKshSJRj8 InNRi56hltMZMv6DiEDS72mqLxtYLN5lc3Xo7QxZjinKqegSHd4qUk0TBSQ5VbqG+G xW1Rr6qJ/LePhg9N7wimGc8G+oI8of7kDDOhjjug= Received: from [10.0.0.170] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3B83C1E030; Wed, 21 Feb 2024 12:36:26 -0500 (EST) Message-ID: <499636ca-75b0-4a4b-a685-4c84f4523665@simark.ca> Date: Wed, 21 Feb 2024 12:36:25 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] gdb: remove some GCC version checks Content-Language: fr To: Kevin Buettner , Simon Marchi Cc: gdb-patches@sourceware.org References: <20240221164709.54212-1-simon.marchi@efficios.com> <20240221100928.62ad46c4@f39-zbm-amd> From: Simon Marchi In-Reply-To: <20240221100928.62ad46c4@f39-zbm-amd> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/21/24 12:09, Kevin Buettner wrote: > On Wed, 21 Feb 2024 11:46:51 -0500 > Simon Marchi wrote: > >> New in v2: >> >> - remove changes to nat/x86-gcc-cpuid.h >> - adjust indentation in tracepoint.h >> >> Since we now require C++17, and therefore gcc >= 9, it's no longer >> useful to have gcc version checks for older gcc version. > > Both patches LGTM. > > Reviewed-by: Kevin Buettner > Thanks. I'll wait for a confirmation from Pedro as well, since he gave comment on v1. Simon