From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105315 invoked by alias); 22 Jun 2017 09:51:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105305 invoked by uid 89); 22 Jun 2017 09:51:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Jun 2017 09:51:22 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A73077CE19; Thu, 22 Jun 2017 09:51:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A73077CE19 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A73077CE19 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id BF1EA61F26; Thu, 22 Jun 2017 09:51:20 +0000 (UTC) Subject: Re: [PATCH v2] environ-selftests: Ignore -Wself-move warning To: Simon Marchi , gdb-patches@sourceware.org References: <1498076108-29914-2-git-send-email-simon.marchi@ericsson.com> <1498120280-17996-1-git-send-email-simon.marchi@ericsson.com> Cc: sergiodj@sergiodj.net From: Pedro Alves Message-ID: <49a24b04-421e-fb52-547b-0f980416d041@redhat.com> Date: Thu, 22 Jun 2017 09:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1498120280-17996-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00627.txt.bz2 On 06/22/2017 09:31 AM, Simon Marchi wrote: > +#if defined (__clang__) > + > +#define DIAG_PUSH_IGNORE_SELF_MOVE \ > + _Pragma("clang diagnostic push") \ > + _Pragma("clang diagnostic ignored \"-Wself-move\"") > +#define DIAG_POP_IGNORE_SELF_MOVE _Pragma("clang diagnostic pop") > + > +#else > + > +#define DIAG_PUSH_IGNORE_SELF_MOVE > +#define DIAG_POP_IGNORE_SELF_MOVE > + > +#endif Let me try writing a quick patch that puts a "STRINGIZE" macro in common/preprocessor.h, so we can write the above like I had suggested before, which is a bit more generic. There are several copies in the tree of such a macro, so that'll be a good thing on its own anyway, IMO. I'm not sure whether the single push-ignore macro is a good idea, since if we follow the pattern going forward, it requires more boilerplace if we need different warnings around the same code: { DIAG_PUSH_IGNORE_WARN1 DIAG_PUSH_IGNORE_WARN2 DIAG_PUSH_IGNORE_WARN3 ... // some code DIAG_POP_IGNORE_WARN3 DIAG_POP_IGNORE_WARN2 DIAG_POP_IGNORE_WARN1 } vs: { DIAG_PUSH DIAG_IGNORE_WARN1 DIAG_IGNORE_WARN2 DIAG_IGNORE_WARN3 ... // some code DIAG_POP } Though we can always support both styles. Thanks, Pedro Alves