From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109947 invoked by alias); 20 Sep 2017 15:25:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109871 invoked by uid 89); 20 Sep 2017 15:25:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=keith, awesome X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Sep 2017 15:25:05 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5608961464 for ; Wed, 20 Sep 2017 15:25:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 5608961464 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9C2915C670; Wed, 20 Sep 2017 15:25:03 +0000 (UTC) Subject: Re: [PATCH 1/2] Fix "list ambiguous_variable" To: Keith Seitz , gdb-patches@sourceware.org References: <1504550858-27936-1-git-send-email-palves@redhat.com> <1504550858-27936-2-git-send-email-palves@redhat.com> From: Pedro Alves Message-ID: <49a8a021-3d9f-c5f1-9cc4-dae1f32c7d01@redhat.com> Date: Wed, 20 Sep 2017 15:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00495.txt.bz2 On 09/06/2017 07:41 PM, Keith Seitz wrote: > On 09/04/2017 11:47 AM, Pedro Alves wrote: >> The "list" command allows specifying the name of variables as >> argument, not just functions, so that users can type "list >> a_global_variable". >> >> That support is a broken when it comes to ambiguous locations though. > > Very nice! > > FWIW, I have only one trivial nit (below). > > Keith > > PS. Out of curiosity, I hacked up a test program with multiple symbols named "ambiguous," both functions and variables. Well done! Awesome. :-) > > (gdb) set listsize 3 > (gdb) list ambiguous > file: "amb1.c", line number: 5, symbol: "ambiguous" > 4 > 5 static int ambiguous = 0; > 6 > file: "amb2.c", line number: 3, symbol: "ambiguous" > 2 ambiguous (void) > 3 { > 4 return 0; > file: "amb3.c", line number: 3, symbol: "ambiguous" > 2 ambiguous (void) > 3 { > 4 return 0; > file: "amb4.c", line number: 1, symbol: "ambiguous" > 1 static int ambiguous = 0; > 2 > 3 int > >> - /* The minimal symbol might point to a function descriptor; >> - resolve it to the actual code address instead. */ >> - pc = gdbarch_convert_from_func_ptr_addr (gdbarch, sal.pc, ¤t_target); >> - if (pc != sal.pc) >> - sal = find_pc_sect_line (pc, NULL, 0); >> + /* The minimal symbol might point to a function descriptor; >> + resolve it to the actual code address instead. */ >> + pc = gdbarch_convert_from_func_ptr_addr (gdbarch, sal.pc, ¤t_target); > > This line exceeds the 80-char line length limit. Indeed it does. Fixed before pushing (both patches). Thanks for the review! -- Pedro Alves