public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Subject: Re: [pushed 1/3] [gdb/testsuite] Fix gdb.cp/*.exp for remote host
Date: Thu, 23 Mar 2023 14:49:38 +0100	[thread overview]
Message-ID: <49b2c817-787d-4f86-6976-7e3f168a852b@suse.de> (raw)
In-Reply-To: <74dd1fa6-b4b4-183c-e46a-66e5d6abedd4@suse.de>

On 3/23/23 01:18, Tom de Vries wrote:
> On 3/22/23 16:05, Simon Marchi wrote:
>>
>>
>> On 3/22/23 04:38, Tom de Vries via Gdb-patches wrote:
>>> Fix a few test-cases in gdb.cp/*.exp for remote host using new proc
>>> include_file.
>>
>> Starting with this patch, I see:
>>
>>      info variable everywhere^M
>>      All variables matching regular expression "everywhere":^M
>>      ^M
>>      File 
>> /home/simark/src/binutils-gdb/gdb/testsuite/gdb.cp/m-static.h:^M
>>      8:      const int gnu_obj_4::everywhere;^M
>>      (gdb) FAIL: gdb.cp/m-static.exp: info variable everywhere
>>
> 
> Hi Simon,
> 
> thanks for reporting this.
> 
> I don't see this on openSUSE Leap 15.4 and Tumbleweed, but I managed to 
> reproduce on Ubuntu 20.04 (though with the readnow board, it disappears 
> again).
> 
> Anyway, the problem is that I changed the matching to be more strict, 
> and that's what we're seeing the effect of.  I'll propose a patch that 
> reverts things to the way things were before, with less strict matching.
> 

Proposed patch is here ( 
https://sourceware.org/pipermail/gdb-patches/2023-March/198240.html ).

> As for what I'm seeing:
> ...
> (gdb) info variable everywhere^M
> All variables matching regular expression "everywhere":^M
> ^M
> File /data/vries/gdb/src/gdb/testsuite/gdb.cp/m-static.h:^M
> 8:      const int gnu_obj_4::everywhere;^M
> ^M
> File /data/vries/gdb/src/gdb/testsuite/gdb.cp/m-static1.cc:^M
> 8:      const int gnu_obj_4::everywhere;^M
> (gdb) PASS: gdb.cp/m-static.exp: info variable everywhere
> ...
> the combination of line 8 with m-static1.cc doesn't seem to make sense.
> 
> I don't know this as a known issue, so I'll file a PR about it.
> 

Filed this PR ( https://sourceware.org/bugzilla/show_bug.cgi?id=30265 ).

Thanks,
- Tom




  reply	other threads:[~2023-03-23 13:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22  8:38 [pushed 0/3] [gdb/testsuite] Fix gdb.cp/*.exp for remote host/target Tom de Vries
2023-03-22  8:38 ` [pushed 1/3] [gdb/testsuite] Fix gdb.cp/*.exp for remote host Tom de Vries
2023-03-22 15:05   ` Simon Marchi
2023-03-23  0:18     ` Tom de Vries
2023-03-23 13:49       ` Tom de Vries [this message]
2023-03-22  8:38 ` [pushed 2/3] [gdb/testsuite] Fix gdb.cp/annota{2,3}.exp for native-extended-gdbserver Tom de Vries
2023-03-22  8:38 ` [pushed 3/3] [gdb/testsuite] Fix gdb.cp/cp-relocate.exp for remote host Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49b2c817-787d-4f86-6976-7e3f168a852b@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).