From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2057.outbound.protection.outlook.com [40.107.21.57]) by sourceware.org (Postfix) with ESMTPS id E2B983882111 for ; Wed, 13 Sep 2023 10:20:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E2B983882111 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vrPF0PNJXleIaEImca9Kz+ar+ysixuEQXb4HM00b/pc=; b=uHR35UJkk7W0MjVdCliBuOKdoyrujN6Y9bch4o5BaQeg0Xw4tZZWZHP+l202ZcX8SbOE8puEUeGPcQoH7iLlZLw7sePih9HRfZ3NVDosMj4zT88RIIcsYA89u5BL2A/waaiJ24wRnsURixbR3aHJVTWovPeYQS16R6cfDy4dAQk= Received: from DUZPR01CA0272.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b9::12) by AS8PR08MB6184.eurprd08.prod.outlook.com (2603:10a6:20b:29c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.19; Wed, 13 Sep 2023 10:20:51 +0000 Received: from DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4b9:cafe::a) by DUZPR01CA0272.outlook.office365.com (2603:10a6:10:4b9::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.19 via Frontend Transport; Wed, 13 Sep 2023 10:20:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT022.mail.protection.outlook.com (100.127.142.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.19 via Frontend Transport; Wed, 13 Sep 2023 10:20:51 +0000 Received: ("Tessian outbound d084e965c4eb:v175"); Wed, 13 Sep 2023 10:20:50 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2e357ed0714c6944 X-CR-MTA-TID: 64aa7808 Received: from e7f1e5bfe9e4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 809B38CE-2714-4C69-AA94-A10F85BE10B6.1; Wed, 13 Sep 2023 10:20:43 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e7f1e5bfe9e4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 13 Sep 2023 10:20:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OzJUJNv2PdRVJciHvJozt0Ys8zQPl0xYLnCwTEoebaJci23UVJQh01Kbr7/O4zdppcNclgbuhQDHTlY0Hj0xpOyLsVOTxn/CIG78lt6esJNKP6tW2DIY67jlIlBn+dfqQujbQk4RMjaansIlVT0E5IzEVnREiIgXF8LsbUWMd79IwFXpGmIPrNvDH9vfILwuuJFhdiG9k8wzvjaXrWDXt7GqwYWdRxDVERqeKXJljjWzgiUWnIlJhGQ0ylc21JAqtrbdZ/gR6E2FjnyOTOSKLqXE0/JCwN5PlFyw2mTwyBpDI+UFCd+p6IcVYqX5UaXt8qSvZB6LdBrehxFtkgkzWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vrPF0PNJXleIaEImca9Kz+ar+ysixuEQXb4HM00b/pc=; b=V7F9KX9UM9DYmQv0SEBWllhEoXN2exs1BxBmpzOzp+dqMLI1DdGTlKJug4T6HFMVmOZoNwowL2XZ/kEDedSBdfX2HiwGhTDcCaFlND86JtsxyvR/f/3QFjwKKEWR/k2CT000UgmYPa431zL8b0In/JWFDa3WJZHyoaztzcY2wbbAUqk8+WSENd4ilyRVMRleMzRIcL9XJBA7BWahNgqBNixtDv6pHzIpSlgNGyQ16on//gIyw2mJyAkQletIhwBqjhKXAufsgjTG2MXVt9l9POw3R5yKFrq2osSk4K+zKikAxnq09m197x5BD/dt8F8PoqalfS+43dQ/xGSp++Sacg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vrPF0PNJXleIaEImca9Kz+ar+ysixuEQXb4HM00b/pc=; b=uHR35UJkk7W0MjVdCliBuOKdoyrujN6Y9bch4o5BaQeg0Xw4tZZWZHP+l202ZcX8SbOE8puEUeGPcQoH7iLlZLw7sePih9HRfZ3NVDosMj4zT88RIIcsYA89u5BL2A/waaiJ24wRnsURixbR3aHJVTWovPeYQS16R6cfDy4dAQk= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM8PR08MB6386.eurprd08.prod.outlook.com (2603:10a6:20b:362::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6768.37; Wed, 13 Sep 2023 10:20:41 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7743:60fe:4859:2df2]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::7743:60fe:4859:2df2%6]) with mapi id 15.20.6792.019; Wed, 13 Sep 2023 10:20:41 +0000 Message-ID: <49c3c4f2-b4e2-a127-f231-741247cb6166@arm.com> Date: Wed, 13 Sep 2023 11:20:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v5 00/16] SME support for AArch64 gdb/gdbserver on Linux To: Thiago Jung Bauermann , Simon Marchi Cc: gdb-patches@sourceware.org References: <20230907152018.1031257-1-luis.machado@arm.com> <87a5tqydti.fsf@linaro.org> Content-Language: en-US From: Luis Machado In-Reply-To: <87a5tqydti.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN2PR01CA0127.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:6::12) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AM8PR08MB6386:EE_|DBAEUR03FT022:EE_|AS8PR08MB6184:EE_ X-MS-Office365-Filtering-Correlation-Id: 600f8407-3012-4676-4c57-08dbb4431b19 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: t8cuycyBXCIx78LRnipDQebj9Kyz+pqxA38UeUDP5FGFsFkxSHHS3SG+caio6a64jnxA4jvjiAuoDb3G3zTI0FXxDjoAbRjGgziI3ydJsuLGE/GeX73GEICaQZxk1obYFfEWlG4O2Coo/9MaLsHsYMhkLGkfOHmQPizEZkv6VpMZFKTbLBCuuZt/k3VlDGG/F6fli16XPVO1GAPICMzhI5ejUz90omg9CFQTlDaQaPruhOIVDQIh8ajsOZwOsnj4ojaXZYaDNaZTZfZjhYMzJkI0KiJDYURYsBk385eVEfNowawuyJXAe1SWBSXBRXv7I+XU+oWZxBnxaaIrmrE1So32ShtUr6Tz2MyHv/mTE/oup5JIYM6/xmqnZHHi3wy/1bhTtwXo6l6n8yRwYnsfKub4ON+yhWqNoiS3aYJ4J5tOgUR8YxfqNOZW7899kk8RBtuxtAnLjIyRuzTH5E968U2q3kvsYbT7IsFrJapoeqxBpa3kyA0m6buknVtpTVcJNlz27LsBSxE7RJi9PCFipUybwrPRn74njgBcdUeLwLGcLcvfiihfFHUZPoc7mrbEjunb1BOGTEw5oeFmxBb5UrbOkXT8v9eV94PTuj4bZnVEW2uMwh3biSkWfpdrdvMtgJcnfyLspwzAJwCqvR0ndA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(366004)(136003)(376002)(346002)(39860400002)(186009)(1800799009)(451199024)(31696002)(83380400001)(38100700002)(31686004)(2616005)(5660300002)(66946007)(41300700001)(26005)(6506007)(53546011)(6666004)(8936002)(110136005)(66476007)(44832011)(478600001)(4326008)(8676002)(316002)(66556008)(2906002)(86362001)(36756003)(6486002)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6386 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 08dc7699-da06-4cef-294d-08dbb44314d6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +UksR+b2oH9v1caAzOou7xNWVtaf6DHxMtV5zqhmwa4COMUS9qCvB0vX2/8Lu+fzjdSqHbwwNgz3yzJSpPIYGFdA/wBnM/+gRuNPy2voLbyhtMaUnv4y9rPcXuj4LHhcWdwwKharaAPj8UQpunNKwmJ3ehZRRHVHCX6XOsiASuEDZxBBSGbevGVLqJf/LbfTb6oxFlt5mO2lVqeXYEZ/wZpQEbjcuYA86/3UEAl1QqKR8XCCiGFGjordWSTGmbUPay6z+hXq7QH+OSNrukpk2Xc+/qbWzUN1Z5hGcGZoEFEng+d864CNB3VqDs4feHZcMfArFo+6DnPJfx272z4b6B77Rqg26zcbXONBYYPuUDETk+LbVhzMwLWYq5n0mt3lFCjtFmwrh1Ha4m8h8CyZYvsOG54sXLJs8Z7GgarZ98XuK2APBSuj8xfLe1EsCAE95x++zEQUno/nLIHb875TsbqRwNoWWGvpgb+mZos4gTIhcU2mSTcaEpupsiO+tC7h6Y5xJuvshP8Oq4SOkJAXkcX2ohxgLwrtqcX8d3wWQSWU6uRL6QZ9WcUNL1uCezq9BIlULuoK1+U1p+rvnTPs91tyFIlq4+0RDH4bzVibE/btVs6XxYrSsjw1440Ilpm/FqJZ49vjVLhVEVNTVQZwKe/dDwLfV24hgkd85pt7y4ZjNA3qzUl3ySnZEwlevrUpwIMfeQQNTflskTHd6kI8i+rMguKyWPMs+Bd2HJyXsiPE8apWEs3ojw9ddaRHDB2+tjxJC/ExPXJsFEqXoN81lw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(136003)(39860400002)(396003)(346002)(376002)(82310400011)(1800799009)(451199024)(186009)(40470700004)(36840700001)(46966006)(6666004)(478600001)(6506007)(53546011)(6486002)(110136005)(336012)(83380400001)(6512007)(2616005)(26005)(2906002)(41300700001)(70206006)(316002)(44832011)(8936002)(5660300002)(4326008)(8676002)(70586007)(86362001)(31696002)(36756003)(36860700001)(47076005)(82740400003)(81166007)(356005)(40480700001)(40460700003)(31686004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2023 10:20:51.3352 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 600f8407-3012-4676-4c57-08dbb4431b19 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6184 X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, On 9/13/23 04:03, Thiago Jung Bauermann wrote: > > Hello Luis, > > Luis Machado writes: > >> The following series enables SME 1 (Scalable Matrix Extension) support for >> AArch64 gdb and gdbserver. >> >> SME expands on SVE by having a variable-sized matrix (ZA) of dimensions >> SVL x SVL bytes. >> >> The first few patches and some intermediate ones refactor the code and fix >> issues prior to enabling SME support, and thus could go in independently. >> >> I've kept them in the series as they are closely/logically related. >> >> Luis Machado (16): >> [gdb/aarch64] Fix register fetch/store order for native AArch64 Linux >> [gdb/aarch64] refactor: Rename SVE-specific files >> [gdb/gdbserver] refactor: Simplify SVE interface to read/write >> registers >> [gdb/aarch64] sve: Fix return command when using V registers in a >> SVE-enabled target >> [gdb/aarch64] sme: Enable SME registers and pseudo-registers >> [gdbserver/aarch64] refactor: Adjust expedited registers dynamically >> [gdbserver/aarch64] sme: Add support for SME >> [gdb/aarch64] sve: Fix signal frame z/v register restore >> [gdb/aarch64] sme: Signal frame support >> [gdb/aarch64] sme: Fixup sigframe gdbarch when vg/svg changes >> [gdb/aarch64] sme: Support TPIDR2 signal frame context >> [gdb/generic] corefile/bug: Use thread-specific gdbarch when dumping >> register state to core files >> [gdb/generic] corefile/bug: Fixup (gcore) core file target description >> reading order >> [gdb/aarch64] sme: Core file support for Linux >> [gdb/testsuite] sme: Add SVE/SME testcases >> [gdb/docs] sme: Document SME registers and features > > FWIW, I have gone through the patch series and haven't found any issues. > Thank you for addressing my comments. > > So apart from the patches where Simon found some issues: > > Reviewed-by: Thiago Jung Bauermann > Thanks. I sent v6/SME1 and v4/SME2 now. If Simon is happy with the changes in v6, I plan to push that version and also v4/SME2.