Re: [PATCH v3 4/9] [gdb/testsuite] use args as lib list for jit-elf tests

[Simon Marchi <simark@simark.ca>]

On 2020-03-31 1:13 p.m., Mihails Strasuns via Gdb-patches wrote:
> @@ -106,49 +106,38 @@ int mypid;
>  int
>  MAIN (int argc, char *argv[])
>  {
> -  /* These variables are here so they can easily be set from jit.exp.  */
> -  const char *libname = NULL;
> -  int count = 0, i, fd;
> -  struct stat st;
> -
> +  int i;
>    alarm (300);
> +  char* fake_argv[10]; // used as backing storage for GDB to populate argv

Space goes before the start: `char *fake_argv`.  For comments, please follow the
usual style:

- Capital letter and period (two spaces after the final period).
- On the line before, not the same line.
- /* */, not //

> @@ -146,31 +149,23 @@ proc one_jit_test {count match_str reattach} {
>      }
>  }
>  
> -if {[compile_jit_test jit.exp "" {}] < 0} {
> -    return
> -}
> -one_jit_test 1 "${hex}  jit_function_0000" 0
> -one_jit_test 2 "${hex}  jit_function_0000\[\r\n\]+${hex}  jit_function_0001" 0
> +compile_jit_main "" {}
> +compile_n_jit_so 2

I mentioned ealier: if we fail to compile the test program, we don't want to execute the rest
of the test case.  That's what the previous code did.  Can you keep that?

Simon