From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 9611F3861882 for ; Thu, 21 Dec 2023 20:24:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9611F3861882 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9611F3861882 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703190292; cv=none; b=X5gSfy3Nx9sik2SCmsyuaEuJi85EJPWA/5EL/OgfwP7BpdpMn+q7Xxj4VzrvUsTvU3o1WNzfx+ZAQwJn3xetjQWtcJQ5iXpVyo4LbsCnfTOcuEJOxVUToVN98hEEcEdFrg3EF1QTELPcVnolBUCOF+w9/L+aFcpJ/O2zn9evQHg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703190292; c=relaxed/simple; bh=M27QkpqL6cMzVsOwp94fL4YlxEng7EEEOM7deeBl5NA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Ut1zW11pA3a1Oy8uajg2UdSC3Eb6r++cotYuvzSE+MHu5G8nvWSxXsjiB805E2UtnCa43yClvGmNBTWTsPXMQ5gbI9C18ke7z8GYe90lYHBYCVLfaP9IXs9G5yq2APQnb4F1j44dQWSlsX6BN5p9eSWA+/tye/cgV00yyw0f2eE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1703190291; bh=M27QkpqL6cMzVsOwp94fL4YlxEng7EEEOM7deeBl5NA=; h=Date:Subject:To:References:From:In-Reply-To:From; b=qgMeZwT+cJXNc0aEM9Vk44/k3YPQFT9G8Ybh6LIDOKltMQkfCbol+kNSqTV/gRsTq 5avNMP48480Q6zjuwv/9ZG/u5nWU2sYBa/nworq3Z4xky8Vueks1GFZqqrzozL/RN4 VWWmQpJ4+M222dXOaKiZia/preqWFtPUldLhOTOY= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2F97A1E0AC; Thu, 21 Dec 2023 15:24:51 -0500 (EST) Message-ID: <49f2562c-d8f6-44d8-b2be-ed250991a0b1@simark.ca> Date: Thu, 21 Dec 2023 15:24:50 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/26] gdbserver: boolify and defaultize the 'fetch' parameter of get_thread_regcache Content-Language: fr To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <6f7de05f02980779a4e6c723598a563ee831e3f2.1677582744.git.tankut.baris.aktemur@intel.com> From: Simon Marchi In-Reply-To: <6f7de05f02980779a4e6c723598a563ee831e3f2.1677582744.git.tankut.baris.aktemur@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/28/23 06:28, Tankut Baris Aktemur via Gdb-patches wrote: > Boolify the 'fetch' parameter of the get_thread_regcache function. > > All of the current uses pass true for this parameter. Therefore, define > its default value as true and remove the argument from the uses. > > We still keep the parameter, though, to give downstream targets the > option to obtain a regcache without having to fetch the whole > contents. Our (Intel) downstream target is an example. Just to understand better, can you explain what is the rationale of your usage of fetch == false? In any case, this LGTM, I think you can push it on its own, it's a good cleanup. Approved-By: Simon Marchi Simon