From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30637 invoked by alias); 22 Mar 2010 17:59:34 -0000 Received: (qmail 30628 invoked by uid 22791); 22 Mar 2010 17:59:33 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 22 Mar 2010 17:59:29 +0000 Received: from jupiter.vmware.com (mailhost5.vmware.com [10.16.68.131]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id D001133085 for ; Mon, 22 Mar 2010 10:59:25 -0700 (PDT) Received: from [10.20.124.100] (promd-2s-dhcp100.eng.vmware.com [10.20.124.100]) by jupiter.vmware.com (Postfix) with ESMTP id BEEEEDC297 for ; Mon, 22 Mar 2010 10:59:25 -0700 (PDT) Message-ID: <4BA7AFFD.6050308@vmware.com> Date: Mon, 22 Mar 2010 17:59:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.22 (X11/20090609) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: Re: [RFA] gdbserver support for qCRC: (compare-sections) References: <4BA40867.4090703@vmware.com> In-Reply-To: <4BA40867.4090703@vmware.com> Content-Type: multipart/mixed; boundary="------------020604040509070008080500" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00765.txt.bz2 This is a multi-part message in MIME format. --------------020604040509070008080500 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 456 Michael Snyder wrote: > This patch adds support to gdbserver for the "qCRC:" request. > > This in turn supports the gdb "compare-sections" command, which > basically lets you verify that the binary image on the target > matches the executable that you're debugging. > > I borrowed code from gdb/remote.c, I assume that's OK. Fixed a "fixme" comment, now will return "E01" if the request tries to read memory that isn't there. Revised patch attached. --------------020604040509070008080500 Content-Type: text/plain; name="qcrc32.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="qcrc32.txt" Content-length: 2363 2010-03-19 Michael Snyder * server.c (crc32): New function. (handle_query): Add handling for 'qCRC:' request. Index: server.c =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/server.c,v retrieving revision 1.108 diff -u -p -r1.108 server.c --- server.c 20 Jan 2010 22:55:38 -0000 1.108 +++ server.c 22 Mar 2010 17:57:32 -0000 @@ -788,6 +788,47 @@ handle_threads_qxfer (const char *annex, } +/* Table used by the crc32 function to calcuate the checksum. */ + +static unsigned long crc32_table[256] = +{0, 0}; + +/* Compute 32 bit CRC from inferior memory. + + On success, return 32 bit CRC. + On failure, return (unsigned long long) -1. */ + +static unsigned long long +crc32 (CORE_ADDR base, int len, unsigned int crc) +{ + if (!crc32_table[1]) + { + /* Initialize the CRC table and the decoding table. */ + int i, j; + unsigned int c; + + for (i = 0; i < 256; i++) + { + for (c = i << 24, j = 8; j > 0; --j) + c = c & 0x80000000 ? (c << 1) ^ 0x04c11db7 : (c << 1); + crc32_table[i] = c; + } + } + + while (len--) + { + unsigned char byte = 0; + + /* Return failure if memory read fails. */ + if (read_inferior_memory (base, &byte, 1) != 0) + return (unsigned long long) -1; + + crc = (crc << 8) ^ crc32_table[((crc >> 24) ^ byte) & 255]; + base++; + } + return (unsigned long long) crc; +} + /* Handle all of the extended 'q' packets. */ void handle_query (char *own_buf, int packet_len, int *new_packet_len_p) @@ -1421,6 +1462,31 @@ handle_query (char *own_buf, int packet_ return; } + if (strncmp ("qCRC:", own_buf, 5) == 0) + { + /* CRC check (compare-segment). */ + char *comma; + CORE_ADDR base = strtoul (own_buf + 5, &comma, 16); + int len; + unsigned long long crc; + + if (*comma++ != ',') + { + write_enn (own_buf); + return; + } + len = strtoul (comma, NULL, 16); + crc = crc32 (base, len, 0xffffffff); + /* Check for memory failure. */ + if (crc == (unsigned long long) -1) + { + write_enn (own_buf); + return; + } + sprintf (own_buf, "C%lx", (unsigned long) crc); + return; + } + /* Otherwise we didn't know what packet it was. Say we didn't understand it. */ own_buf[0] = 0; --------------020604040509070008080500--