From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71357-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 659 invoked by alias); 23 Mar 2010 22:44:30 -0000
Received: (qmail 649 invoked by uid 22791); 23 Mar 2010 22:44:29 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Mar 2010 22:44:24 +0000
Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) 	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 5F9942B011; 	Tue, 23 Mar 2010 15:44:21 -0700 (PDT)
Received: from [10.20.125.19] (unknown [10.20.125.19]) 	by mailhost2.vmware.com (Postfix) with ESMTP id 558948E627; 	Tue, 23 Mar 2010 15:44:21 -0700 (PDT)
Message-ID: <4BA94444.6060706@vmware.com>
Date: Tue, 23 Mar 2010 22:44:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.22 (X11/20090609)
MIME-Version: 1.0
To: Pedro Alves <pedro@codesourcery.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] gdbserver support for qCRC: (compare-sections)
References: <4BA40867.4090703@vmware.com> <201003231626.13757.pedro@codesourcery.com> <4BA9056D.8050206@vmware.com> <201003231832.12355.pedro@codesourcery.com>
In-Reply-To: <201003231832.12355.pedro@codesourcery.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg00802.txt.bz2

Pedro Alves wrote:
> On Tuesday 23 March 2010 18:16:13, Michael Snyder wrote:
>>> A `require_running' call is missing here.
>> Sorry, what's that?  I'm not familiar with it.
> 
> See the other queries being handled in
> server.c:handle_query.  Literally, see the
> 
>  require_running (own_buf);
> 
> calls.
> 
> If you connect with "target extended-remote"
> instead of "target remote", and do "compare-sections" before
> issueing "run" or "attach" from gdb, hence gdbserver has no
> inferior process to debug yet, you want gdbserver to reply
> error (E01) instead of trying to read from a non-existing
> inferior process (and possibly crashing).

OK, committed, thanks.