A patch I'd like to propose.

A patch I'd like to propose.

[Chris Moller]

[-- Attachment #1: Type: text/plain, Size: 131 bytes --]

Adds the command "quickquit," aliased to "qq," to cli/cli-cmds.c.   It 
eliminates that annoying quit_confirm() when quitting gdb.

[-- Attachment #2: quickquit.patch --]
[-- Type: text/x-patch, Size: 1689 bytes --]

Index: cli-cmds.c
===================================================================
RCS file: /cvs/src/src/gdb/cli/cli-cmds.c,v
retrieving revision 1.100
diff -u -r1.100 cli-cmds.c
--- cli-cmds.c	9 Apr 2010 03:00:58 -0000	1.100
+++ cli-cmds.c	14 Apr 2010 11:49:19 -0000
@@ -329,7 +329,7 @@
   immediate_quit--;
 }
 
-/* Handle the quit command.  */
+/* Handle the quit commands.  */
 
 void
 quit_command (char *args, int from_tty)
@@ -342,6 +342,14 @@
   quit_force (args, from_tty);
 }
 
+void
+quick_quit_command (char *args, int from_tty)
+{
+  disconnect_tracing (from_tty);
+
+  quit_force (args, from_tty);
+}
+
 static void
 pwd_command (char *args, int from_tty)
 {
@@ -1400,10 +1408,13 @@
 			show_script_ext_mode,
 			&setlist, &showlist);
 
+  add_com ("quickquit", class_support, quick_quit_command,
+	   _("Exit gdb without confirmation."));
   add_com ("quit", class_support, quit_command, _("Exit gdb."));
   c = add_com ("help", class_support, help_command,
 	       _("Print list of commands."));
   set_cmd_completer (c, command_completer);
+  add_com_alias ("qq", "quickquit", class_support, 1);
   add_com_alias ("q", "quit", class_support, 1);
   add_com_alias ("h", "help", class_support, 1);
 
Index: cli-cmds.h
===================================================================
RCS file: /cvs/src/src/gdb/cli/cli-cmds.h,v
retrieving revision 1.14
diff -u -r1.14 cli-cmds.h
--- cli-cmds.h	1 Jan 2010 07:31:46 -0000	1.14
+++ cli-cmds.h	14 Apr 2010 11:49:19 -0000
@@ -119,6 +119,7 @@
 
 /* Exported to gdb/top.c and gdb/main.c */
 
+extern void quick_quit_command (char *, int);
 extern void quit_command (char *, int);
 
 extern void source_script (char *, int);

Re: A patch I'd like to propose.

[Phil Muldoon]

On 04/14/2010 12:59 PM, Chris Moller wrote:
> Adds the command "quickquit," aliased to "qq," to cli/cli-cmds.c.   It
> eliminates that annoying quit_confirm() when quitting gdb.

'set confirm off' works for me?  Though this is not the default it
seems.  Is this orthogonal to your request, or did you want an
explicit command to act regardless of confirm off/on?

Re: A patch I'd like to propose.

[Chris Moller]

On 04/14/10 10:19, Phil Muldoon wrote:
> On 04/14/2010 12:59 PM, Chris Moller wrote:
>    
>> Adds the command "quickquit," aliased to "qq," to cli/cli-cmds.c.   It
>> eliminates that annoying quit_confirm() when quitting gdb.
>>      
>
> 'set confirm off' works for me?  Though this is not the default it
> seems.  Is this orthogonal to your request, or did you want an
> explicit command to act regardless of confirm off/on?
>    

I'm looking for something that always works without me having to make 
any special arrangement for it.  I use a lot of bizarre environments in 
debugging and a lot of the time I've forgotten things like copying over 
my usual~/.gdbinit

Re: A patch I'd like to propose.

[Joel Brobecker]

> Adds the command "quickquit," aliased to "qq," to cli/cli-cmds.c.
> It eliminates that annoying quit_confirm() when quitting gdb.

I like the idea of being able to quit without having to confirm.
Either a new command, or using a switch? We seem to be using command
switches more and more, lately.  I assume we want to make this
sufficiently more convienient than typing y-ENTER, so maybe "qq"
is the way to go...

-- 
Joel

Re: A patch I'd like to propose.

[Michael Snyder]

Joel Brobecker wrote:
>> Adds the command "quickquit," aliased to "qq," to cli/cli-cmds.c.
>> It eliminates that annoying quit_confirm() when quitting gdb.
> 
> I like the idea of being able to quit without having to confirm.
> Either a new command, or using a switch? We seem to be using command
> switches more and more, lately.  I assume we want to make this
> sufficiently more convienient than typing y-ENTER, so maybe "qq"
> is the way to go...
> 

I don't suppose "q!"....   just kidding!  ;-)

Re: A patch I'd like to propose.

[Pedro Alves]

On Wednesday 14 April 2010 15:29:24, Chris Moller wrote:
> On 04/14/10 10:19, Phil Muldoon wrote:
> > On 04/14/2010 12:59 PM, Chris Moller wrote:
> >    
> >> Adds the command "quickquit," aliased to "qq," to cli/cli-cmds.c.   It
> >> eliminates that annoying quit_confirm() when quitting gdb.
> >>      
> >
> > 'set confirm off' works for me?  Though this is not the default it
> > seems.  Is this orthogonal to your request, or did you want an
> > explicit command to act regardless of confirm off/on?
> >    
> 
> I'm looking for something that always works without me having to make 
> any special arrangement for it.  I use a lot of bizarre environments in 
> debugging and a lot of the time I've forgotten things like copying over 
> my usual~/.gdbinit

That's what you should be fixing then, isn't it?  ;-)

 define qq
   set confirm off
   quit
 end

Kinda misses the scripting point we add commands for everything
that's _already_ easily possible, even with CLI scripting.

In any case, I'd be okay with this with the following constrains:

* It was rather called "quit-force", or something similarly, so that:

 - q<tab> does't stop completing to "quit", but instead even
   proposes "quit"/"quit-force" to the user.  As bonus, users notice
   the new command is available.

 - the fact that `qq' is typo-prone is avoided.  E.g., "quit-force" -> qf.

* q, qu, qui, remain unambiguous aliases to "quit".  "quickquit" shares
3 initials with "quit", so q will stop working if aliases are not added.

* You explain whether you mean for this to disable _all_ queries
when quitting or not.  I think that's what you meant.  As is, it
doesn't do that, because e.g.,

 +void
 +quick_quit_command (char *args, int from_tty)
 +{
 +  disconnect_tracing (from_tty);
    ^^^^^^^^^^^^^^^^^^

This can query.

 +
 +  quit_force (args, from_tty);
 +}

* Of course, that this is documented in the manual.

-- 
Pedro Alves