From: Michael Snyder <msnyder@vmware.com>
To: Doug Evans <dje@sebabeach.org>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Hui Zhu <teawater@gmail.com>
Subject: Re: [RFA] target record_core -> target record-core?
Date: Mon, 19 Apr 2010 18:01:00 -0000 [thread overview]
Message-ID: <4BCC9A5B.7010907@vmware.com> (raw)
In-Reply-To: <20100419064717.75D476E3DC@sebabeach.org>
Doug Evans wrote:
> I realize this is a nit but is it possible to rename
> target record_core to target record-core?
> Or is it too late ...
>
> All other targets (that I know of) use dashes in shortname, and having
> to remember which use dashes and which use underscores is, umm, blechy.
> [Unless we have and enforce a convention, it can only get worse,
> so might as well establish one now - if it doesn't exist already.]
I don't think anybody uses it, so this should be ok.
Hui?
>
> 2010-04-18 Doug Evans <dje@sebabeach.org>
>
> * record.c (init_record_core_ops): Rename record_core to record_core.
>
> Index: record.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/record.c,v
> retrieving revision 1.44
> diff -u -p -r1.44 record.c
> --- record.c 8 Mar 2010 13:34:38 -0000 1.44
> +++ record.c 19 Apr 2010 06:44:51 -0000
> @@ -1863,7 +1863,7 @@ record_core_has_execution (struct target
> static void
> init_record_core_ops (void)
> {
> - record_core_ops.to_shortname = "record_core";
> + record_core_ops.to_shortname = "record-core";
> record_core_ops.to_longname = "Process record and replay target";
> record_core_ops.to_doc =
> "Log program while executing and replay execution from log.";
next prev parent reply other threads:[~2010-04-19 18:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 6:47 Doug Evans
2010-04-19 18:01 ` Michael Snyder [this message]
2010-04-20 9:56 ` Pedro Alves
2010-04-20 12:24 ` Hui Zhu
2010-04-20 18:06 ` Tom Tromey
2010-04-20 18:11 ` Joel Brobecker
2010-04-23 20:40 ` Patch: completion -vs- deprecated commands (Was: [RFA] target record_core -> target record-core?) Tom Tromey
2010-04-26 18:37 ` Patch: completion -vs- deprecated commands Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCC9A5B.7010907@vmware.com \
--to=msnyder@vmware.com \
--cc=dje@sebabeach.org \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).