From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25625 invoked by alias); 19 Apr 2010 18:01:08 -0000 Received: (qmail 25283 invoked by uid 22791); 19 Apr 2010 18:01:06 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 19 Apr 2010 18:01:02 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 15F223B003; Mon, 19 Apr 2010 11:01:00 -0700 (PDT) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id 04512CD91F; Mon, 19 Apr 2010 11:01:00 -0700 (PDT) Message-ID: <4BCC9A5B.7010907@vmware.com> Date: Mon, 19 Apr 2010 18:01:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.22 (X11/20090609) MIME-Version: 1.0 To: Doug Evans CC: "gdb-patches@sourceware.org" , Hui Zhu Subject: Re: [RFA] target record_core -> target record-core? References: <20100419064717.75D476E3DC@sebabeach.org> In-Reply-To: <20100419064717.75D476E3DC@sebabeach.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00566.txt.bz2 Doug Evans wrote: > I realize this is a nit but is it possible to rename > target record_core to target record-core? > Or is it too late ... > > All other targets (that I know of) use dashes in shortname, and having > to remember which use dashes and which use underscores is, umm, blechy. > [Unless we have and enforce a convention, it can only get worse, > so might as well establish one now - if it doesn't exist already.] I don't think anybody uses it, so this should be ok. Hui? > > 2010-04-18 Doug Evans > > * record.c (init_record_core_ops): Rename record_core to record_core. > > Index: record.c > =================================================================== > RCS file: /cvs/src/src/gdb/record.c,v > retrieving revision 1.44 > diff -u -p -r1.44 record.c > --- record.c 8 Mar 2010 13:34:38 -0000 1.44 > +++ record.c 19 Apr 2010 06:44:51 -0000 > @@ -1863,7 +1863,7 @@ record_core_has_execution (struct target > static void > init_record_core_ops (void) > { > - record_core_ops.to_shortname = "record_core"; > + record_core_ops.to_shortname = "record-core"; > record_core_ops.to_longname = "Process record and replay target"; > record_core_ops.to_doc = > "Log program while executing and replay execution from log.";