From: Michael Snyder <msnyder@vmware.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Pedro Alves <pedro@codesourcery.com>
Subject: Re: [RFA] gdb.trace, replace wildcard regexp
Date: Fri, 11 Jun 2010 22:47:00 -0000 [thread overview]
Message-ID: <4C12BCE7.7010403@vmware.com> (raw)
In-Reply-To: <201006111701.o5BH1tlT007147@d12av02.megacenter.de.ibm.com>
Ulrich Weigand wrote:
> Michael Snyder wrote:
>
>> --- gdb.trace/packetlen.exp 2 Jun 2010 21:55:28 -0000 1.14
>> +++ gdb.trace/packetlen.exp 4 Jun 2010 18:02:31 -0000
>> @@ -34,8 +34,8 @@ if { [gdb_compile "$srcdir/$subdir/$srcf
>> return -1
>> }
>> gdb_load $binfile
>> -gdb_test "tstop" "" ""
>> -gdb_test "tfind none" "" ""
>> +gdb_test "tstop" ".*" ""
>> +gdb_test "tfind none" ".*" ""
>> runto_main
>> gdb_reinitialize_dir $srcdir/$subdir
>>
>> @@ -48,7 +48,7 @@ gdb_reinitialize_dir $srcdir/$subdir
>> #
>>
>> gdb_delete_tracepoints
>> -gdb_test "trace gdb_c_test" "" ""
>> +gdb_test "trace gdb_c_test" ".*" ""
>> gdb_trace_setactions "setup collect actions" \
>> "" \
>> "collect parm\[0\], parm\[1\], parm\[2\], parm\[3\]" "^$" \
>> @@ -61,7 +61,7 @@ gdb_trace_setactions "setup collect acti
>> "end" ""
>>
>> gdb_test_no_output "tstart" "survive the long packet send"
>> -gdb_test "break end" "" ""
>> +gdb_test "break end" ".*" ""
>> gdb_test "continue" \
>> "Continuing.*Breakpoint $decimal, end.*" \
>> "run trace experiment"
>
> This change also causes new FAILs for me:
>
> (gdb) PASS: gdb.trace/packetlen.exp: setup collect actions
> tstart^M
> You can't do that when your target is `child'^M
> (gdb) FAIL: gdb.trace/packetlen.exp: survive the long packet send
> break end^M
> Breakpoint 3 at 0x760: file /home/uweigand/fsf/gdb-head/gdb/testsuite/gdb.trace/actions.c, line 110.^M
> (gdb) continue^M
> Continuing.^M
> ^M
> Breakpoint 3, end () at /home/uweigand/fsf/gdb-head/gdb/testsuite/gdb.trace/actions.c:110^M
> 110 }^M
> (gdb) PASS: gdb.trace/packetlen.exp: run trace experiment
> tstop^M
> Trace is not running.^M
> (gdb) FAIL: gdb.trace/packetlen.exp: confirm: survived the long packet send
Yeah, but these ones really do fail, when the target can't do
tracepoints. They need to be run against gdbserver.
Odd, though, most of the trace tests bail early if the target
can't do tracepoints. They don't give arbitrary failures...
next prev parent reply other threads:[~2010-06-11 22:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-04 18:05 Michael Snyder
2010-06-08 23:00 ` Michael Snyder
2010-06-11 17:02 ` Ulrich Weigand
2010-06-11 22:47 ` Michael Snyder [this message]
2010-06-11 23:30 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C12BCE7.7010403@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).