From: Phil Muldoon <pmuldoon@redhat.com>
To: tromey@redhat.com
Cc: Doug Evans <dje@google.com>, gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [python][patch] Inferior and Thread information support.
Date: Fri, 18 Jun 2010 20:10:00 -0000 [thread overview]
Message-ID: <4C1BD2B2.80503@redhat.com> (raw)
In-Reply-To: <m3wrtwmdcx.fsf@fleche.redhat.com>
On 06/18/2010 06:58 PM, Tom Tromey wrote:
>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
>
> Phil> I'm not sure that conversion from a Python type to a buffer object are
> Phil> that transparent. For instance there seems to be no straightforward
> Phil> way to represent 3.141 as a sequence of bytes backed by a buffer in
> Phil> Python (or accessible via the buffer interface rather). Maybe there
> Phil> is, I'm certainly not a Python language expert. I hope someone can
> Phil> prove me wrong!
>
> Yeah, there are some things in Python for this. See the 'struct'
> module.
>
> I think it is somewhat better to keep our API simple and rely on the
> built-in library for more complicated things. Sorry about that.
Simplifying the API will be the easy part (though I disagree on it),
it just means removing code. I'll submit a patch for that next week.
>
> Phil> Right now with the existing code, we take 3.141 as a gdb.value and
> Phil> convert that to bytes via value_contents. Your suggestions would
> Phil> certainly make the existing code simpler (and my porting task a little
> Phil> easier ;), but I can't help thinking that it would be just making the
> Phil> user jump through extra hoops just for API pureness. I strive for
> Phil> that, it's a good thing; it just strikes me a little too much in this
> Phil> case. OTOH we could just make add_value_pattern available via the API
> Phil> and have the user manually do the conversion "the GDB way".
>
> Arguably, gdb.Value should support the buffer protocol. I don't know if
> that is directly possible, but if not we should supply a way to convert
> a Value to a buffer -- to give the user a way to view the underlying
> bits.
I don't disagree in principle. I'm not sure this is within the
the scope of this patch though?
> I think you should just remove the max_count argument. It seems weird
> to me. If people want multiple searches, it is easy to iterate. Or, if
> we really want to support multiple searches, then I think we should do
> it by returning an iterator instead of a list.
From a pragmatic point of view, between you and Doug I'm a little lost
about what we need to do to get this patch suitable for inclusion in
the FSF tree, with a possible view for inclusion to 7.2? I'm not sure
what the removal of the max_count has to do with the other comments?
Making search_memory only support buffers is okay from the Python
side, that is easy. What else needs to be done is my question ;)
Cheers,
Phil
next prev parent reply other threads:[~2010-06-18 20:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-24 13:36 Phil Muldoon
2010-05-24 18:06 ` Eli Zaretskii
2010-06-10 18:40 ` Tom Tromey
2010-06-14 12:42 ` Phil Muldoon
2010-06-15 15:24 ` Pedro Alves
2010-06-15 18:11 ` Tom Tromey
2010-06-15 18:24 ` Pedro Alves
2010-06-15 19:58 ` Phil Muldoon
2010-06-15 20:36 ` Pedro Alves
2010-06-18 6:49 ` Phil Muldoon
2010-06-18 14:21 ` Doug Evans
2010-06-18 15:47 ` Phil Muldoon
2010-06-18 17:59 ` Tom Tromey
2010-06-18 20:10 ` Phil Muldoon [this message]
2010-06-25 20:41 ` Tom Tromey
2010-06-18 18:04 ` Tom Tromey
2010-06-22 10:32 ` Phil Muldoon
2010-06-25 20:38 ` Tom Tromey
2010-06-28 9:22 ` Phil Muldoon
2010-06-28 19:51 ` Tom Tromey
2010-06-28 21:35 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1BD2B2.80503@redhat.com \
--to=pmuldoon@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).