From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12756 invoked by alias); 12 Jul 2010 18:03:59 -0000 Received: (qmail 12699 invoked by uid 22791); 12 Jul 2010 18:03:58 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,TW_CP,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Jul 2010 18:03:53 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6CI3qDv003824 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 12 Jul 2010 14:03:52 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6CI3p6p021456 for ; Mon, 12 Jul 2010 14:03:52 -0400 Received: from [10.15.16.129] (dhcp-10-15-16-129.yyz.redhat.com [10.15.16.129]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o6CI3pAZ010880 for ; Mon, 12 Jul 2010 14:03:51 -0400 Message-ID: <4C3B5907.2080200@redhat.com> Date: Mon, 12 Jul 2010 18:03:00 -0000 From: sami wagiaalla User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Thunderbird/3.0.5 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [patch 1/3] Change cplus_specific to an alocated struct References: <4BFD4230.3030600@redhat.com> <4C167FCA.7030300@redhat.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------080001000106020206030802" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-07/txt/msg00210.txt.bz2 This is a multi-part message in MIME format. --------------080001000106020206030802 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 53 This patch cplus_specific is renamed to mangled_lang --------------080001000106020206030802 Content-Type: text/plain; name="dynamic-cplus_specific_1.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="dynamic-cplus_specific_1.patch" Content-length: 5110 commit 91022b44617e9fbf1430280fa4f6b3476a4b015d Author: Sami Wagiaalla Date: Wed Jul 7 13:45:46 2010 -0400 Rename cplus_specific mangled_lang. 2010-07-12 Sami Wagiaalla * symtab.h: Renamed cplus_specific to mangled_lang. * symtab.c (symbol_init_language_specific): Updated. (symbol_set_names): Updated. (symbol_natural_name): Updated. (symbol_demangled_name): Updated. * ada-lang.c (ada_decode_symbol): Updated. * dwarf2read.c (new_symbol): Updated. diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index 1d4c38b..fabb272 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -1210,7 +1210,7 @@ char * ada_decode_symbol (const struct general_symbol_info *gsymbol) { char **resultp = - (char **) &gsymbol->language_specific.cplus_specific.demangled_name; + (char **) &gsymbol->language_specific.mangled_lang.demangled_name; if (*resultp == NULL) { diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index bab1fba..8dd239d 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -8673,8 +8673,8 @@ new_symbol (struct die_info *die, struct type *type, struct dwarf2_cu *cu) /* Fortran does not have mangling standard and the mangling does differ between gfortran, iFort etc. */ if (cu->language == language_fortran - && sym->ginfo.language_specific.cplus_specific.demangled_name == NULL) - sym->ginfo.language_specific.cplus_specific.demangled_name + && sym->ginfo.language_specific.mangled_lang.demangled_name == NULL) + sym->ginfo.language_specific.mangled_lang.demangled_name = (char *) dwarf2_full_name (name, die, cu); /* Default assumptions. diff --git a/gdb/symtab.c b/gdb/symtab.c index cada00e..7e9873e 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -354,7 +354,7 @@ symbol_init_language_specific (struct general_symbol_info *gsymbol, || gsymbol->language == language_objc || gsymbol->language == language_fortran) { - gsymbol->language_specific.cplus_specific.demangled_name = NULL; + gsymbol->language_specific.mangled_lang.demangled_name = NULL; } else { @@ -537,7 +537,7 @@ symbol_set_names (struct general_symbol_info *gsymbol, memcpy (gsymbol->name, linkage_name, len); gsymbol->name[len] = '\0'; } - gsymbol->language_specific.cplus_specific.demangled_name = NULL; + gsymbol->language_specific.mangled_lang.demangled_name = NULL; return; } @@ -633,10 +633,10 @@ symbol_set_names (struct general_symbol_info *gsymbol, gsymbol->name = (*slot)->mangled + lookup_len - len; if ((*slot)->demangled[0] != '\0') - gsymbol->language_specific.cplus_specific.demangled_name + gsymbol->language_specific.mangled_lang.demangled_name = (*slot)->demangled; else - gsymbol->language_specific.cplus_specific.demangled_name = NULL; + gsymbol->language_specific.mangled_lang.demangled_name = NULL; } /* Return the source code name of a symbol. In languages where @@ -652,12 +652,12 @@ symbol_natural_name (const struct general_symbol_info *gsymbol) case language_java: case language_objc: case language_fortran: - if (gsymbol->language_specific.cplus_specific.demangled_name != NULL) - return gsymbol->language_specific.cplus_specific.demangled_name; + if (gsymbol->language_specific.mangled_lang.demangled_name != NULL) + return gsymbol->language_specific.mangled_lang.demangled_name; break; case language_ada: - if (gsymbol->language_specific.cplus_specific.demangled_name != NULL) - return gsymbol->language_specific.cplus_specific.demangled_name; + if (gsymbol->language_specific.mangled_lang.demangled_name != NULL) + return gsymbol->language_specific.mangled_lang.demangled_name; else return ada_decode_symbol (gsymbol); break; @@ -679,12 +679,12 @@ symbol_demangled_name (const struct general_symbol_info *gsymbol) case language_java: case language_objc: case language_fortran: - if (gsymbol->language_specific.cplus_specific.demangled_name != NULL) - return gsymbol->language_specific.cplus_specific.demangled_name; + if (gsymbol->language_specific.mangled_lang.demangled_name != NULL) + return gsymbol->language_specific.mangled_lang.demangled_name; break; case language_ada: - if (gsymbol->language_specific.cplus_specific.demangled_name != NULL) - return gsymbol->language_specific.cplus_specific.demangled_name; + if (gsymbol->language_specific.mangled_lang.demangled_name != NULL) + return gsymbol->language_specific.mangled_lang.demangled_name; else return ada_decode_symbol (gsymbol); break; diff --git a/gdb/symtab.h b/gdb/symtab.h index 5b109ce..ded0ae3 100644 --- a/gdb/symtab.h +++ b/gdb/symtab.h @@ -124,12 +124,12 @@ struct general_symbol_info union { - struct cplus_specific + struct mangled_lang { /* This is in fact used for C++, Java, and Objective C. */ char *demangled_name; } - cplus_specific; + mangled_lang; } language_specific; --------------080001000106020206030802--