public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: sami wagiaalla <swagiaal@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [patch] create and use symbol_set_language
Date: Thu, 05 Aug 2010 15:36:00 -0000	[thread overview]
Message-ID: <4C5ADA7C.8060101@redhat.com> (raw)
In-Reply-To: <000c01cb33a6$89450260$9bcf0720$@muller@ics-cnrs.unistra.fr>

Hi Pierre,

Thanks for the review :)

>    The removal of the 'gsymbol->language == language_cplus'
> condition seems to be outside of the scope of the patch you
> describe, which seems otherwise quite straightforward.
>
>    Could you please comment on the reason of that specific change?
> Is it really part of that patch or shouldn't it be submitted
> separately? I must confess that I didn't even try to
> look at the source code after the 'if', but just reacted quickly
> on something that seem 'off topic' as compared to
> your patch description.
>

I guess Doug has already answered this question. The check for 
language_cplus was redundant. This should have had a better Changelog 
entry of course, or been on separate patch :)... I'll fix it

Sami

  reply	other threads:[~2010-08-05 15:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-03 14:56 sami wagiaalla
2010-08-04  7:27 ` Pierre Muller
2010-08-05 15:36   ` sami wagiaalla [this message]
     [not found] ` <6308127460174723176@unknownmsgid>
2010-08-04 21:56   ` Doug Evans
2010-08-04 22:01     ` Doug Evans
2010-08-05 19:05     ` sami wagiaalla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C5ADA7C.8060101@redhat.com \
    --to=swagiaal@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).