From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23773 invoked by alias); 5 Aug 2010 15:36:37 -0000 Received: (qmail 23759 invoked by uid 22791); 5 Aug 2010 15:36:36 -0000 X-SWARE-Spam-Status: No, hits=-6.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Aug 2010 15:36:31 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o75FaTbQ017049 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 5 Aug 2010 11:36:30 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o75FaT4k031420 for ; Thu, 5 Aug 2010 11:36:29 -0400 Received: from [10.15.16.129] (dhcp-10-15-16-129.yyz.redhat.com [10.15.16.129]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o75FaSqQ017350 for ; Thu, 5 Aug 2010 11:36:29 -0400 Message-ID: <4C5ADA7C.8060101@redhat.com> Date: Thu, 05 Aug 2010 15:36:00 -0000 From: sami wagiaalla User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Thunderbird/3.0.5 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [patch] create and use symbol_set_language References: <4C582E25.1030505@redhat.com> <000c01cb33a6$89450260$9bcf0720$@muller@ics-cnrs.unistra.fr> In-Reply-To: <000c01cb33a6$89450260$9bcf0720$@muller@ics-cnrs.unistra.fr> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00037.txt.bz2 Hi Pierre, Thanks for the review :) > The removal of the 'gsymbol->language == language_cplus' > condition seems to be outside of the scope of the patch you > describe, which seems otherwise quite straightforward. > > Could you please comment on the reason of that specific change? > Is it really part of that patch or shouldn't it be submitted > separately? I must confess that I didn't even try to > look at the source code after the 'if', but just reacted quickly > on something that seem 'off topic' as compared to > your patch description. > I guess Doug has already answered this question. The check for language_cplus was redundant. This should have had a better Changelog entry of course, or been on separate patch :)... I'll fix it Sami