From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26710 invoked by alias); 10 Aug 2010 14:34:39 -0000 Received: (qmail 26698 invoked by uid 22791); 10 Aug 2010 14:34:37 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Aug 2010 14:34:31 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7AEYTQ3032509 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 10 Aug 2010 10:34:29 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7AEYTkr003895 for ; Tue, 10 Aug 2010 10:34:29 -0400 Received: from [10.15.16.129] (dhcp-10-15-16-129.yyz.redhat.com [10.15.16.129]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o7AEYS8j027930 for ; Tue, 10 Aug 2010 10:34:28 -0400 Message-ID: <4C616374.7080700@redhat.com> Date: Tue, 10 Aug 2010 14:34:00 -0000 From: sami wagiaalla User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Thunderbird/3.0.5 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: Regression gdb.cp/temargs.exp: test value of P in inner_m [Re: [patch] Defer symbol addition until construction is complete] References: <4C446F09.50107@redhat.com> <4C604B22.4060904@redhat.com> <20100810074402.GA19162@host1.dyn.jankratochvil.net> In-Reply-To: <20100810074402.GA19162@host1.dyn.jankratochvil.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00123.txt.bz2 On 08/10/2010 03:44 AM, Jan Kratochvil wrote: > On Mon, 09 Aug 2010 20:38:26 +0200, sami wagiaalla wrote: >> Complete symbol construction before adding to pending list. >> >> 2010-08-09 Sami Wagiaalla >> >> * dwarf2read.c (new_symbol): Add symbol to variable list at end of >> function after symbol construction is complete. >> Do the same for template symbol addition to template_symbols list. > > checked-in as: > http://sourceware.org/ml/gdb-cvs/2010-08/msg00040.html > 3b26cb4b133031280fa022e2a06e58f333ed5e8d > >> Is this cool ? > > This patch has a cold regression. :-) > > -PASS: gdb.cp/temargs.exp: test value of P in inner_m > +FAIL: gdb.cp/temargs.exp: test value of P in inner_m > : Okay let me take a look. Thanks for letting me know. Sami