From: Phil Muldoon <pmuldoon@redhat.com>
To: gdb-patches ml <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@redhat.com>,
Joel Brobecker <brobecker@adacore.com>,
Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] Add solib_address and decode_line Python functionality
Date: Wed, 11 Aug 2010 13:16:00 -0000 [thread overview]
Message-ID: <4C62A292.6030702@redhat.com> (raw)
In-Reply-To: <m3tyn2comu.fsf@fleche.redhat.com>
On 10/08/10 19:24, Tom Tromey wrote:
>>>>>> "Phil" == Phil Muldoon <pmuldoon@redhat.com> writes:
> Eli> This is okay, but I would suggest to explain what happens without the
> Eli> argument first. Readers shouldn't need to read all the description of
> Eli> how the argument is parsed if they don't want to pass it.
>
> Phil> > I've used your re-ordering in this patch, too.
>
> Eli> I'm happy now. Thanks.
>
> Tom> So, could you make this conditional?
>
> Phil> Sure, what do you think of the attached patch?
>
> Tom> Thanks for persevering. This is ok.
So committed. Thanks
http://sourceware.org/ml/gdb-cvs/2010-08/msg00051.html
Cheers,
Phil
next prev parent reply other threads:[~2010-08-11 13:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-19 15:43 Phil Muldoon
2010-07-27 16:26 ` Joel Brobecker
2010-07-28 11:35 ` Phil Muldoon
2010-07-28 17:39 ` Joel Brobecker
2010-07-28 17:48 ` Eli Zaretskii
2010-07-29 20:39 ` Tom Tromey
2010-08-06 13:55 ` Phil Muldoon
2010-08-06 15:36 ` Eli Zaretskii
2010-08-06 22:39 ` Tom Tromey
2010-08-10 11:17 ` Phil Muldoon
2010-08-10 17:07 ` Eli Zaretskii
2010-08-10 18:24 ` Tom Tromey
2010-08-11 13:16 ` Phil Muldoon [this message]
2010-08-13 14:07 ` Ken Werner
2010-08-13 14:14 ` Phil Muldoon
2010-08-13 15:48 ` Tom Tromey
2010-08-13 16:22 ` Ken Werner
2010-08-18 23:55 ` Pedro Alves
2010-08-19 16:32 ` Tom Tromey
2010-08-19 17:04 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C62A292.6030702@redhat.com \
--to=pmuldoon@redhat.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).