public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Phil Muldoon <pmuldoon@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: implement "watch -location"
Date: Thu, 12 Aug 2010 08:17:00 -0000	[thread overview]
Message-ID: <4C63AE20.4060102@redhat.com> (raw)
In-Reply-To: <m38w4c7qne.fsf@fleche.redhat.com>

On 11/08/10 23:04, Tom Tromey wrote:
> This patch steals an idea from Apple's gdb fork, namely "watch -location".
> I wrote this from scratch but in the end it looks pretty similar to what
> they did.
> 
> In my experience, I generally don't want gdb's scope-tracking logic for
> watchpoint expressions.  Instead, I'm usually just interested in some
> bit of memory.  I find myself typing this a lot:
> 
> print &expr
> watch *$
> 
> This patch adds an option to "watch" to let me do this more directly.
> (FWIW, this is a frequently-asked question on #gdb.)
> 
> I did not add an MI option for this (something Apple did do).
> It didn't seem necessary to me.
> 
> I also didn't add Python API for this.  I'm on the fence about whether
> it is needed.


Nice patch!

I guess we could get around it by massaging the data in Python before
passing it as an expression to the Breakpoint API.  It would be nice,
however, to maintain parity with the command line.  I'm on the fence
too, but if you don't implement it I probably will (eventually).

Cheers,

Phil


  parent reply	other threads:[~2010-08-12  8:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-11 22:04 Tom Tromey
2010-08-11 22:11 ` Michael Snyder
2010-08-11 22:15   ` Tom Tromey
2010-08-12  2:45     ` Hui Zhu
2010-08-12  7:55     ` André Pönitz
2010-08-12  3:07 ` Eli Zaretskii
2010-08-12  8:17 ` Phil Muldoon [this message]
2010-08-13 16:39 ` Jan Kratochvil
2010-08-13 18:27   ` Tom Tromey
2010-08-16 19:54     ` Jan Kratochvil
2010-08-13 18:25 ` Tom Tromey
2010-08-13 19:19   ` Eli Zaretskii
2010-08-13 21:21   ` Jan Kratochvil
2010-08-13 21:24     ` Tom Tromey
2010-08-16 18:13       ` Tom Tromey
2010-08-16 18:43         ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C63AE20.4060102@redhat.com \
    --to=pmuldoon@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).