From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12200 invoked by alias); 13 Aug 2010 14:14:47 -0000 Received: (qmail 12189 invoked by uid 22791); 13 Aug 2010 14:14:46 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 13 Aug 2010 14:14:39 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7DEEL4N007356 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 13 Aug 2010 10:14:21 -0400 Received: from Phil-THINK.home (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7DEEKUS014534; Fri, 13 Aug 2010 10:14:20 -0400 Message-ID: <4C65533B.5000006@redhat.com> Date: Fri, 13 Aug 2010 14:14:00 -0000 From: Phil Muldoon User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Thunderbird/3.1.1 MIME-Version: 1.0 To: Ken Werner CC: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [patch] Add solib_address and decode_line Python functionality References: <4C44728D.4040408@redhat.com> <4C613540.9090009@redhat.com> <201008131607.09618.ken@linux.vnet.ibm.com> In-Reply-To: <201008131607.09618.ken@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00188.txt.bz2 On 13/08/10 15:07, Ken Werner wrote: > On Tuesday, August 10, 2010 08:24:09 pm Tom Tromey wrote: >>>>>>> "Phil" == Phil Muldoon writes: >> Tom> So, could you make this conditional? >> >> Phil> Sure, what do you think of the attached patch? >> >> Thanks for persevering. This is ok. > > Hi, > > It looks like the const qualifier of the format string argument of the > PyArg_Parse* routines has been introduced after the Python 2.4 release: > http://svn.python.org/view?view=rev&revision=41638 > In case gdb is built against libpython 2.4 the current code would generate a > warning. One solution would be to just remove the const qualifier. A small > patch is attached. Any comments are appreciated. Thanks for catching this. It looks fine to me; but wait for Tom or another maintainer to give the official nod first. Cheers Phil