From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25205 invoked by alias); 19 Aug 2010 18:03:34 -0000 Received: (qmail 25104 invoked by uid 22791); 19 Aug 2010 18:03:32 -0000 X-SWARE-Spam-Status: No, hits=-4.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Aug 2010 18:03:26 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 8736627005; Thu, 19 Aug 2010 11:03:25 -0700 (PDT) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost4.vmware.com (Postfix) with ESMTP id 7BFDAC9B75; Thu, 19 Aug 2010 11:03:25 -0700 (PDT) Message-ID: <4C6D71ED.2020206@vmware.com> Date: Thu, 19 Aug 2010 18:03:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.22 (X11/20090609) MIME-Version: 1.0 To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: Re: FYI: make python install directory References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00347.txt.bz2 Tom Tromey wrote: > I'm checking this in on the trunk and the 7.2 branch. > > PR 11900 says that gdb's breaks help with Python 2.4. > This happens because the gdb module's __path__ points to a directory > which does not exist. > > This patch fixes the problem by arranging to make the appropriate > directory at install time. > > Joel, I'm afraid your patches in this area will need a small update. > Or you can just back this out when those go in -- it doesn't matter at > all to me. I went with this very minimal patch just because it seems > important to fix for 7.2. This seems to generate a new build error for me: mkdir cannot create /usr/share/gdb Permission denied > 2010-08-18 Tom Tromey > > PR python/11900: > * configure: Rebuild. > * configure.ac: Add install-python to CONFIG_INSTALL. > * Makefile.in (install-python): New. > > Index: Makefile.in > =================================================================== > RCS file: /cvs/src/src/gdb/Makefile.in,v > retrieving revision 1.1127.2.1 > diff -u -r1.1127.2.1 Makefile.in > --- Makefile.in 28 Jul 2010 18:32:47 -0000 1.1127.2.1 > +++ Makefile.in 18 Aug 2010 22:52:22 -0000 > @@ -1037,6 +1037,8 @@ > $(INSTALL_DATA) $(srcdir)/gdb.1 \ > $(DESTDIR)$(man1dir)/$$transformed_name.1 > > +install-python: > + $(SHELL) $(srcdir)/../mkinstalldirs $(GDB_DATADIR)/python/gdb > > uninstall: force $(CONFIG_UNINSTALL) > transformed_name=`t='$(program_transform_name)'; \ > Index: configure.ac > =================================================================== > RCS file: /cvs/src/src/gdb/configure.ac,v > retrieving revision 1.125.2.2 > diff -u -r1.125.2.2 configure.ac > --- configure.ac 30 Jul 2010 16:02:16 -0000 1.125.2.2 > +++ configure.ac 18 Aug 2010 22:52:23 -0000 > @@ -832,6 +832,7 @@ > CONFIG_OBS="$CONFIG_OBS \$(SUBDIR_PYTHON_OBS)" > CONFIG_DEPS="$CONFIG_DEPS \$(SUBDIR_PYTHON_DEPS)" > CONFIG_SRCS="$CONFIG_SRCS \$(SUBDIR_PYTHON_SRCS)" > + CONFIG_INSTALL="$CONFIG_INSTALL install-python" > ENABLE_CFLAGS="$ENABLE_CFLAGS \$(SUBDIR_PYTHON_CFLAGS)" > > # Flags needed to compile Python code (taken from python-config --cflags).