From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26673 invoked by alias); 20 Aug 2010 20:21:19 -0000 Received: (qmail 26665 invoked by uid 22791); 20 Aug 2010 20:21:18 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_BJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Aug 2010 20:21:10 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7KKL96M015520 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 20 Aug 2010 16:21:09 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7KKL9pr008977 for ; Fri, 20 Aug 2010 16:21:09 -0400 Received: from [10.11.9.237] (vpn-9-237.rdu.redhat.com [10.11.9.237]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o7KKL8ps022237 for ; Fri, 20 Aug 2010 16:21:08 -0400 Message-ID: <4C6EE3B4.1090906@redhat.com> Date: Fri, 20 Aug 2010 20:21:00 -0000 From: sami wagiaalla User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.7) Gecko/20100720 Fedora/3.1.1-1.fc13 Thunderbird/3.1.1 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: Regression gdb.cp/temargs.exp: test value of P in inner_m [Re: [patch] Defer symbol addition until construction is complete] References: <4C446F09.50107@redhat.com> <4C604B22.4060904@redhat.com> <20100810074402.GA19162@host1.dyn.jankratochvil.net> <4C616374.7080700@redhat.com> In-Reply-To: <4C616374.7080700@redhat.com> Content-Type: multipart/mixed; boundary="------------070309070007090607050202" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00373.txt.bz2 This is a multi-part message in MIME format. --------------070309070007090607050202 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 596 >> -PASS: gdb.cp/temargs.exp: test value of P in inner_m >> +FAIL: gdb.cp/temargs.exp: test value of P in inner_m >> : > > Okay let me take a look. Thanks for letting me know. > Apologies it took so long to get back to this I had some difficulty setting up the environment. The original patch: http://sourceware.org/ml/gdb-cvs/2010-08/msg00040.html 3b26cb4b133031280fa022e2a06e58f333ed5e8d suppressed one too many regressions. Specifically (if you look at 3b26cb4b133^) the regression on line 10185 when the tag is DW_TAG_template_value_param and DW_AT_location != NULL. Patch attached. --------------070309070007090607050202 Content-Type: text/x-patch; name="regression.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="regression.patch" Content-length: 548 Fix defer add regression. 2010-08-20 Sami Wagiaalla * dwarf2read.c (new_symbol_full): Do not set list_to_add to NULL if suppress_add == 1. diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index 78491c8..cd1c084 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -10330,7 +10330,6 @@ new_symbol_full (struct die_info *die, struct type *type, struct dwarf2_cu *cu, { sym->hash_next = objfile->template_symbols; objfile->template_symbols = sym; - list_to_add = NULL; } if (list_to_add != NULL) --------------070309070007090607050202--