From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-75242-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15022 invoked by alias); 30 Aug 2010 17:34:06 -0000
Received: (qmail 14883 invoked by uid 22791); 30 Aug 2010 17:34:05 -0000
X-SWARE-Spam-Status: No, hits=-4.6 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Aug 2010 17:33:56 +0000
Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124])	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 85A444016;	Mon, 30 Aug 2010 10:33:52 -0700 (PDT)
Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138])	by mailhost4.vmware.com (Postfix) with ESMTP id 77C06C9B19;	Mon, 30 Aug 2010 10:33:52 -0700 (PDT)
Message-ID: <4C7BEB80.9020002@vmware.com>
Date: Mon, 30 Aug 2010 17:34:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 2.0.0.24 (X11/20100702)
MIME-Version: 1.0
To: Jan Kratochvil <jan.kratochvil@redhat.com>
CC: Mark Kettenis <mark.kettenis@xs4all.nl>,  "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch 1/9]#2 Rename `enum target_signal' to target_signal_t
References: <20100830071040.GB6831@host1.dyn.jankratochvil.net> <201008300814.o7U8ECNZ009010@glazunov.sibelius.xs4all.nl> <20100830082407.GA6881@host1.dyn.jankratochvil.net>
In-Reply-To: <20100830082407.GA6881@host1.dyn.jankratochvil.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-08/txt/msg00524.txt.bz2

Jan Kratochvil wrote:
> On Mon, 30 Aug 2010 10:14:12 +0200, Mark Kettenis wrote:
>> The _t suffix is actually reserved by POSIX, so using it is actually a
>> bad idea.  Perhaps change it to gdb_target_signal, or just
>> target_signal (making it a typedef for an anonymous enum)?
> 
> I see too many types in GDB and everywhere ending with _t (ptid_t for all).
> 
> I do not mind at all about the type name but before reposting the patchset
> I would like agreement from one more global maintainer.

ptid_t was an extension from pid_t, which is a posix typedef I think.