From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 978 invoked by alias); 31 Aug 2010 15:18:23 -0000 Received: (qmail 967 invoked by uid 22791); 31 Aug 2010 15:18:22 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 31 Aug 2010 15:18:17 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7VFIFib021878 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 31 Aug 2010 11:18:16 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7VFIE6m021127 for ; Tue, 31 Aug 2010 11:18:14 -0400 Received: from [10.15.16.129] (dhcp-10-15-16-129.yyz.redhat.com [10.15.16.129]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o7VFIDSs008144 for ; Tue, 31 Aug 2010 11:18:13 -0400 Message-ID: <4C7D1D42.8080501@redhat.com> Date: Tue, 31 Aug 2010 15:18:00 -0000 From: sami wagiaalla User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100806 Fedora/3.1.2-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.2 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: Regression gdb.cp/temargs.exp: test value of P in inner_m [Re: [patch] Defer symbol addition until construction is complete] References: <4C446F09.50107@redhat.com> <4C604B22.4060904@redhat.com> <20100810074402.GA19162@host1.dyn.jankratochvil.net> <4C616374.7080700@redhat.com> <4C6EE3B4.1090906@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00548.txt.bz2 On 08/20/2010 05:54 PM, Tom Tromey wrote: >>>>>> "Sami" == sami wagiaalla writes: > > Sami> suppressed one too many regressions. Specifically (if you look at > Sami> 3b26cb4b133^) the regression on line 10185 when the tag is > Sami> DW_TAG_template_value_param and DW_AT_location != NULL. > > I don't think this patch is correct. > IIUC it will go ahead and add the template parameters to whatever scope > is being read. That isn't right, and in fact that is what suppress_add > was intended to prevent. I looked into this some more. Here is the problem IIUC: The template parameter P in this case is a member of the structure not the function, but, from what I can tell, the template param patch (240d54e9) supports storing and searching of template parameters only if they are members of a function. If that is correct then this patch just exposed that problem as opposed to case the regression. Sami