Pedro Alves wrote: > On Wednesday 01 September 2010 17:56:32, Yao Qi wrote: >> + /* Don't consider single-stepping when the inferior is >> + waiting_for_vfork_done, either software or hardware step. In >> + software step, child process will hit the software single step >> + breakpoint inserted in parent process. In hardware step, GDB >> + can resumes inferior, and waiting for vfork_done event. */ > > This last sentence looks incomplete? At least, I can't seem to > parse it. > I replaced "waiting" by "wait" in the new patch. >> + if (current_inferior()->waiting_for_vfork_done) > > Space before parens. > Fixed. >> if (use_displaced_stepping (gdbarch) >> && (tp->trap_expected >> || (step && gdbarch_software_single_step_p (gdbarch))) >> - && sig == TARGET_SIGNAL_0) >> + && sig == TARGET_SIGNAL_0 >> + && !current_inferior()->waiting_for_vfork_done) > > Space before parens. > Fixed. -- Yao Qi CodeSourcery yao@codesourcery.com (650) 331-3385 x739