From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32051 invoked by alias); 2 Sep 2010 15:36:49 -0000 Received: (qmail 32037 invoked by uid 22791); 2 Sep 2010 15:36:47 -0000 X-SWARE-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Sep 2010 15:36:41 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o82FabWo001551 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 2 Sep 2010 11:36:38 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o82Fabws028292; Thu, 2 Sep 2010 11:36:37 -0400 Received: from [10.15.16.129] (dhcp-10-15-16-129.yyz.redhat.com [10.15.16.129]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o82FaaPc011081; Thu, 2 Sep 2010 11:36:36 -0400 Message-ID: <4C7FC495.8090705@redhat.com> Date: Thu, 02 Sep 2010 15:43:00 -0000 From: sami wagiaalla User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.8) Gecko/20100806 Fedora/3.1.2-1.fc13 Lightning/1.0b2pre Thunderbird/3.1.2 MIME-Version: 1.0 To: Doug Evans CC: Tom Tromey , gdb-patches@sourceware.org Subject: Re: Regression for gdb.stabs/gdb11479.exp [Re: [patch 1/2] Use custom hash function with bcache] References: <4C6946E1.6000709@redhat.com> <4C6D5C83.3050602@redhat.com> <4C756132.5050301@redhat.com> <20100901082539.GA24609@host1.dyn.jankratochvil.net> <20100901161952.GX2986@adacore.com> <20100901164716.GY2986@adacore.com> <4C7E96FA.2080209@redhat.com> <4C7EA30B.7020007@redhat.com> <4C7EA94E.4010104@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00095.txt.bz2 This sounds good to me. If we are not using a static psymbol struct should we zero out the value union at least ? > 2010-09-01 Doug Evans > > * psymtab.c (add_psymbol_to_bcache): Initialize obj_section. > > Index: psymtab.c > =================================================================== > RCS file: /cvs/src/src/gdb/psymtab.c,v > retrieving revision 1.12 > diff -u -p -r1.12 psymtab.c > --- psymtab.c 1 Sep 2010 21:50:26 -0000 1.12 > +++ psymtab.c 1 Sep 2010 22:50:05 -0000 > @@ -1394,6 +1394,7 @@ add_psymbol_to_bcache (char *name, int n > SYMBOL_VALUE_ADDRESS (&psymbol) = coreaddr; > } > SYMBOL_SECTION (&psymbol) = 0; > + SYMBOL_OBJ_SECTION (&psymbol) = NULL; > SYMBOL_SET_LANGUAGE (&psymbol, language); > PSYMBOL_DOMAIN (&psymbol) = domain; > PSYMBOL_CLASS (&psymbol) = class;