From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25625 invoked by alias); 2 Sep 2010 16:51:49 -0000 Received: (qmail 25610 invoked by uid 22791); 2 Sep 2010 16:51:47 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 02 Sep 2010 16:51:37 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o82GpZij020407 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 2 Sep 2010 12:51:36 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o82GpXFB000855 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 2 Sep 2010 12:51:35 -0400 Message-ID: <4C7FD615.7080200@redhat.com> Date: Thu, 02 Sep 2010 17:28:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100720 Fedora/3.0.6-1.fc12 Lightning/1.0b2pre Thunderbird/3.0.6 MIME-Version: 1.0 To: Tom Tromey CC: gdb-patches@sourceware.org Subject: Re: [RFA] Change to pre-expand symtabs References: <4C4DD835.7060702@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00101.txt.bz2 On 09/01/2010 02:32 PM, Tom Tromey wrote: > I'm afraid I am going to kick this one back to you. I'll address this in a follow-up. I wanted to address the regression you found: > This modified patch causes a regression in type-opaque.exp, I didn't research > why. This is happening because match_transparent_type in symtab.c is assuming GLOBAL_BLOCK, even though the desired block type is passed in. With the simple patch below, the regression is gone. May I commit this? [It causes no regressions on x86_64 linux.] Keith ChangeLog 2010-09-02 Keith Seitz * symtab.c (match_transparent_type): Use KIND for determining the appropriate BLOCKVECTOR. Index: symtab.c =================================================================== RCS file: /cvs/src/src/gdb/symtab.c,v retrieving revision 1.252 diff -u -p -r1.252 symtab.c --- symtab.c 1 Sep 2010 21:50:26 -0000 1.252 +++ symtab.c 2 Sep 2010 16:36:58 -0000 @@ -1671,7 +1671,7 @@ match_transparent_type (struct symtab *s struct symbol *sym; bv = BLOCKVECTOR (symtab); - block = BLOCKVECTOR_BLOCK (bv, GLOBAL_BLOCK); + block = BLOCKVECTOR_BLOCK (bv, kind); sym = lookup_block_symbol (block, name, STRUCT_DOMAIN); if (sym && !TYPE_IS_OPAQUE (SYMBOL_TYPE (sym))) return sym;