From: sami wagiaalla <swagiaal@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sourceware.org
Subject: Re: Regression for gdb.stabs/gdb11479.exp [Re: [patch 1/2] Use custom hash function with bcache]
Date: Sat, 04 Sep 2010 14:29:00 -0000 [thread overview]
Message-ID: <4C81547B.3010603@redhat.com> (raw)
In-Reply-To: <AANLkTi=KwykoGq4tYSTgZybuw7ffp0Md6oOBNN4=87NL@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 339 bytes --]
> Blech. "never mind". We do need the memset.
> The hash still includes sizeof (ginfo.value), which is reasonable (I
> thought it didn't for some reason).
> gcc turns it in to a move instruction anyway so no worries there.
Alright, the attached patch memsets value and initializes obj_section as
you suggested. Is this ok to commit ?
[-- Attachment #2: hash_regression.patch --]
[-- Type: text/x-patch, Size: 1092 bytes --]
Fix custom hash regression.
2010-09-03 Sami Wagiaalla <swagiaal@redhat.com>
* psymtab.c (add_psymbol_to_bcache): Initialize
obj_section.
memset psymbol.ginfo.value to 0.
diff --git a/gdb/psymtab.c b/gdb/psymtab.c
index a5d2f98..2f1bfc6 100644
--- a/gdb/psymtab.c
+++ b/gdb/psymtab.c
@@ -1378,6 +1378,11 @@ add_psymbol_to_bcache (char *name, int namelength, int copy_name,
{
struct partial_symbol psymbol;
+ /* We must ensure that the entire 'value' field has been zeroed
+ before assigning to it, because an assignment may not write the
+ entire field. */
+ memset (&psymbol.ginfo.value, 0, sizeof (psymbol.ginfo.value));
+
/* val and coreaddr are mutually exclusive, one of them *will* be zero */
if (val != 0)
{
@@ -1388,6 +1393,7 @@ add_psymbol_to_bcache (char *name, int namelength, int copy_name,
SYMBOL_VALUE_ADDRESS (&psymbol) = coreaddr;
}
SYMBOL_SECTION (&psymbol) = 0;
+ SYMBOL_OBJ_SECTION (&psymbol) = NULL;
SYMBOL_SET_LANGUAGE (&psymbol, language);
PSYMBOL_DOMAIN (&psymbol) = domain;
PSYMBOL_CLASS (&psymbol) = class;
next prev parent reply other threads:[~2010-09-03 20:03 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 14:11 [RFC] Use custom hash function with bcache sami wagiaalla
2010-08-16 18:29 ` Doug Evans
2010-08-16 18:56 ` Doug Evans
2010-08-16 19:56 ` sami wagiaalla
2010-08-19 16:32 ` [patch 1/2] Use custom hash function with bcache [Re: [RFC] Use custom hash function with bcache] sami wagiaalla
2010-08-19 20:26 ` Tom Tromey
2010-08-25 18:30 ` sami wagiaalla
2010-08-30 20:53 ` Tom Tromey
2010-09-01 8:25 ` Regression for gdb.stabs/gdb11479.exp [Re: [patch 1/2] " Jan Kratochvil
2010-09-01 16:20 ` Joel Brobecker
2010-09-01 16:47 ` Joel Brobecker
2010-09-01 17:03 ` sami wagiaalla
2010-09-01 17:17 ` Joel Brobecker
2010-09-01 18:09 ` sami wagiaalla
2010-09-01 18:19 ` Jan Kratochvil
2010-09-01 18:24 ` Doug Evans
2010-09-01 18:38 ` Tom Tromey
2010-09-01 19:01 ` sami wagiaalla
2010-09-01 19:15 ` Doug Evans
2010-09-01 19:17 ` Doug Evans
2010-09-01 19:59 ` sami wagiaalla
2010-09-01 23:11 ` Doug Evans
2010-09-01 23:16 ` Doug Evans
2010-09-01 23:19 ` Doug Evans
2010-09-01 23:19 ` Doug Evans
2010-09-02 15:43 ` sami wagiaalla
2010-09-02 20:25 ` Doug Evans
2010-09-03 15:59 ` Doug Evans
2010-09-04 14:29 ` sami wagiaalla [this message]
2010-09-06 9:46 ` Daniel Jacobowitz
2010-08-16 19:14 ` [RFC] Use custom hash function with bcache Daniel Jacobowitz
2010-08-16 19:50 ` sami wagiaalla
2010-08-16 20:04 ` Daniel Jacobowitz
2010-08-16 20:11 ` sami wagiaalla
2010-08-16 20:49 ` Daniel Jacobowitz
2010-08-17 17:02 ` sami wagiaalla
2010-08-17 17:40 ` Daniel Jacobowitz
2010-08-17 23:26 ` Tom Tromey
2010-08-18 15:13 ` sami wagiaalla
2010-08-18 15:24 ` Tom Tromey
2010-08-19 16:33 ` sami wagiaalla
2010-08-19 16:37 ` [patch 2/2] Use custom hash function with bcache [Re: [RFC] Use custom hash function with bcache] sami wagiaalla
2010-08-19 20:32 ` [RFC] Use custom hash function with bcache Tom Tromey
2010-08-25 18:32 ` [patch 2/2] Use custom hash function with bcache [Re: [RFC] Use custom hash function with bcache] sami wagiaalla
2010-08-30 20:58 ` Tom Tromey
2010-08-30 21:13 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C81547B.3010603@redhat.com \
--to=swagiaal@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).