From: Michael Snyder <msnyder@vmware.com>
To: Jiang Jilin <freephp@gmail.com>
Cc: Hui Zhu <teawater@gmail.com>,
gdb-patches ml <gdb-patches@sourceware.org>,
"tromey@redhat.com" <tromey@redhat.com>
Subject: Re: [PATCH] Rewrite the codes for opcode 0x0f01 and add more instructions support
Date: Fri, 17 Sep 2010 08:33:00 -0000 [thread overview]
Message-ID: <4C929A9C.1050601@vmware.com> (raw)
In-Reply-To: <AANLkTimZi1dV7ao-0kpAfhDogtXnDwcuJPDwEr5hEGVq@mail.gmail.com>
Since it is a pretty actively changing file, it would probably be good
to supply a new diff and changelog, please.
Hui, you should be one of the reviewers, yes?
Jiang Jilin wrote:
> Hi,
>
> I'm very sorry due to my work, however, it's good news that the I've
> finished the paper assignment.
>
> Should I rewrite the patch again? Any comments are welcome!
>
> Thank you!
>
> On Mon, Oct 12, 2009 at 10:21 AM, Jiang Jilin <freephp@gmail.com> wrote:
>> On Mon, Oct 12, 2009 at 10:04 AM, Michael Snyder <msnyder@vmware.com> wrote:
>>> Jiang Jilin wrote:
>>>> Hi, guys
>>>>
>>>> I've rewrite the codes for opcode 0x0f01 with more readable, add
>>>> xgetbv/xsetbv/rdtscp/vmcall/vmlaunch/vmresume/vmxoff instructions
>>>> support as well.
>>>>
>>>> However, I'm *not* sure it's whether right or not, especially with
>>>> the new supported instructions beginning with "vm". And I remove all
>>>> codes to save EFLAGS register which is not specified to be saved by
>>>> Intel's manual, so please help me review them.
>>>>
>>>> Luckily, there is no regression when using precord.exp board file to test.
>>>>
>>>> At last but not least, there is some differences in gdb.sum when
>>>> 'make check' before and after applying this patch. I cannot make
>>>> a decision whether it's correct, so please help me. The diff are
>>>> as follows:
>>> Ah well, but you see, now the change is too big to be accepted
>>> without a copyright assignment. Do you want to start the process
>>> of filing one?
>> I've done as Joel told me, now I just wait for the paper arrival.
>>
>> Anyway, thank you! :)
>>
>>> [Cc: Tom Tromey]
>>>
>> --
>> Jiang
>>
>
>
>
next prev parent reply other threads:[~2010-09-16 22:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1255182393-15292-1-git-send-email-freephp@gmail.com>
[not found] ` <4AD28E95.1050404@vmware.com>
[not found] ` <7d77a27d0910111921v13a8e8acpb98c29a9aa72ed8@mail.gmail.com>
2010-09-16 18:01 ` Jiang Jilin
2010-09-17 8:33 ` Michael Snyder [this message]
2011-03-29 12:07 ` Jiang Jilin
2011-03-29 12:21 ` Yao Qi
2011-03-29 14:28 ` Jiang Jilin
2011-05-19 19:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C929A9C.1050601@vmware.com \
--to=msnyder@vmware.com \
--cc=freephp@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).