From: Edjunior Barbosa Machado <emachado@linux.vnet.ibm.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] testsuite: asm-source.exp: add powerpc64 support
Date: Wed, 10 Nov 2010 13:01:00 -0000 [thread overview]
Message-ID: <4CDA9799.7050905@linux.vnet.ibm.com> (raw)
In-Reply-To: <201011100745.oAA7jFsJ019214@glazunov.sibelius.xs4all.nl>
Hi
On 11/10/2010 05:45 AM, Mark Kettenis wrote:
>> From: Edjunior Barbosa Machado<emachado@linux.vnet.ibm.com>
>> Date: Wed, 10 Nov 2010 05:29:42 -0200
>>
>> Hi,
>>
>> this patch intents to add powerpc64 support to the asm-source.exp
>> testcase. It contains a new include file (powerpc64.inc) which
>> defines macros for ppc64 asm. As some architectures (like ppc64)
>> can have one or more instructions after the subroutine call, the
>> testcase was modified in order to expect the caller line again as
>> well as the next line when issuing "finish" or "return" (as
>> mentioned at http://sourceware.org/ml/gdb/2010-11/msg00032.html).
>> It also has other minor changes, such as expect '.' prefixing
>> ppc64's symbols and call 'sys_exit' sequence on gdbasm_exit0 macro
>> for ppc32.
>>
>> Tested on x86, ppc32 and ppc64.
>>
>> Is that ok?
>
> Why are you making the distinction based on is_lp64_target and not on
> the target tuple (powerpc64*-*-* vs. powerpc*-*-*)?
is_lp64_target is necessary for when you running a 32-bit environment distro (such as RHEL5 and SLES10) in a ppc64 machine (it can not be distinguish by only checking the target tuple).
Thanks,
--
Edjunior
next prev parent reply other threads:[~2010-11-10 13:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 7:30 Edjunior Barbosa Machado
2010-11-10 7:45 ` Mark Kettenis
2010-11-10 13:01 ` Edjunior Barbosa Machado [this message]
2010-11-20 5:34 ` Joel Brobecker
2010-11-23 18:44 ` Edjunior Barbosa Machado
2010-11-23 20:01 ` Joel Brobecker
2010-11-24 18:20 ` Thiago Jung Bauermann
2010-11-23 18:46 ` [PATCH] testsuite: asm-source.exp: use 'sys_exit' on powerpc.inc Edjunior Barbosa Machado
2010-11-24 18:22 ` Thiago Jung Bauermann
2010-11-25 11:23 ` Mark Kettenis
2010-11-25 13:56 ` Edjunior Barbosa Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CDA9799.7050905@linux.vnet.ibm.com \
--to=emachado@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).