From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9799 invoked by alias); 18 Nov 2010 17:44:01 -0000 Received: (qmail 9784 invoked by uid 22791); 18 Nov 2010 17:43:59 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,TW_YM X-Spam-Check-By: sourceware.org Received: from caibbdcaaaaf.dreamhost.com (HELO homiemail-a58.g.dreamhost.com) (208.113.200.5) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Nov 2010 17:43:54 +0000 Received: from homiemail-a58.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a58.g.dreamhost.com (Postfix) with ESMTP id 8BE147D806C; Thu, 18 Nov 2010 09:43:52 -0800 (PST) Received: from redwood.eagercon.com (c-67-188-213-237.hsd1.ca.comcast.net [67.188.213.237]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a58.g.dreamhost.com (Postfix) with ESMTPSA id 24F677D8060; Thu, 18 Nov 2010 09:43:52 -0800 (PST) Message-ID: <4CE565D6.1010009@eagerm.com> Date: Thu, 18 Nov 2010 17:44:00 -0000 From: Michael Eager User-Agent: Thunderbird 2.0.0.23 (X11/20090825) MIME-Version: 1.0 To: Joel Brobecker CC: Masaki Muranaka , gdb-patches@sourceware.org Subject: Re: [patch] target triplet for Microblaze. References: <20101118171030.GA2634@adacore.com> In-Reply-To: <20101118171030.GA2634@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00241.txt.bz2 Joel Brobecker wrote: >> The CVS head can't accept microblaze*-(manufacturer)-elf and >> microblaze*-(manufacturer)-linux* as the target triplet. This >> behavior is not based upon the description in Autobook. >> http://sourceware.org/autobook/autobook/autobook_17.html > > I don't mind allowing another manufacturer than xilinx in the target > triplet for the microblaze, but I'm just curious. Are there any others? > If that's the case, perhaps we want to adjust the comments saying > "Xilinx Microblaze" and remove "Xilinx"... MicroBlaze is a proprietary processor developed by Xilinx and, AFAIK, they have not licensed it to other manufacturers. Xilinx is the only possible specification which meets the definition in Autobook. > Also, `microblaze*-linux-*' is there to allow "microblaze-linux-gnu". > I'm not sure this is really kosher or not. I would think not (we're in > danger of thinking that the OS name is "gnu" rather than "linux". But > keeping it if needed shouldn't be too much of a burden as long as this > is limited to configure.tgt. Perhaps this would be better as "microblaze*-*-linux" like other targets. > >> 2010-11-18 Masaki Muranaka >> >> * configure.tgt: Accept microblaze*-*-linux* for linux target >> and microblaze*-*-* for as target. > > Other than that, this seems fine to me. Cc'ing Michael Eager > in case he has any additional comment. Thanks. I haven't been following gdb-patches until now. :-\ >> - - - - - >> diff --git a/gdb/configure.tgt b/gdb/configure.tgt >> index bca2260..e065e70 100644 >> --- a/gdb/configure.tgt >> +++ b/gdb/configure.tgt >> @@ -323,14 +323,14 @@ mep-*-*) >> # No sim needed. Target uses SID. >> ;; >> >> -microblaze*-linux-*) >> +microblaze*-linux-*|microblaze*-*-linux*) >> # Target: Xilinx MicroBlaze running Linux >> gdb_target_obs="microblaze-tdep.o microblaze-linux-tdep.o microblaze-rom.o >> monitor.o dsrec.o solib.o solib-svr4.o corelow.o \ >> symfile-mem.o linux-tdep.o" >> gdb_sim=../sim/microblaze/libsim.a >> ;; >> -microblaze*-xilinx-*) >> +microblaze*-*-*) >> # Target: Xilinx MicroBlaze running standalone >> gdb_target_obs="microblaze-tdep.o microblaze-rom.o monitor.o dsrec.o" >> gdb_sim=../sim/microblaze/libsim.a gcc/config.gcc has "microblaze*-*-*" and "microblaze*-linux*". This should be updated to be compatible. Patch is OK with me. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077