[patch] target triplet for Microblaze.

[patch] target triplet for Microblaze.

[Masaki Muranaka]

Hello,
I have a question.

The CVS head can't accept microblaze*-(manufacturer)-elf and microblaze*-(manufacturer)-linux* as the target triplet.
This behavior is not based upon the description in Autobook.
http://sourceware.org/autobook/autobook/autobook_17.html

The patch is below.
It might we should remove microblaze*-linux-*. But I left it for the backward compatibility.

ok to apply?

- - - - -
2010-11-18  Masaki Muranaka  <monaka@monami-software.com>

        * configure.tgt: Accept microblaze*-*-linux* for linux target
        and microblaze*-*-* for  as target.
- - - - -
diff --git a/gdb/configure.tgt b/gdb/configure.tgt
index bca2260..e065e70 100644
--- a/gdb/configure.tgt
+++ b/gdb/configure.tgt
@@ -323,14 +323,14 @@ mep-*-*)
        # No sim needed. Target uses SID.
        ;;
 
-microblaze*-linux-*)
+microblaze*-linux-*|microblaze*-*-linux*)
        # Target: Xilinx MicroBlaze running Linux
        gdb_target_obs="microblaze-tdep.o microblaze-linux-tdep.o microblaze-rom.o 
                        monitor.o dsrec.o solib.o solib-svr4.o corelow.o \
                        symfile-mem.o linux-tdep.o"
        gdb_sim=../sim/microblaze/libsim.a
        ;;
-microblaze*-xilinx-*)
+microblaze*-*-*)
        # Target: Xilinx MicroBlaze running standalone
        gdb_target_obs="microblaze-tdep.o microblaze-rom.o monitor.o dsrec.o"
        gdb_sim=../sim/microblaze/libsim.a

Re: [patch] target triplet for Microblaze.

[Joel Brobecker]

> The CVS head can't accept microblaze*-(manufacturer)-elf and
> microblaze*-(manufacturer)-linux* as the target triplet.  This
> behavior is not based upon the description in Autobook.
> http://sourceware.org/autobook/autobook/autobook_17.html

I don't mind allowing another manufacturer than xilinx in the target
triplet for the microblaze, but I'm just curious. Are there any others?
If that's the case, perhaps we want to adjust the comments saying
"Xilinx Microblaze" and remove "Xilinx"...

Also, `microblaze*-linux-*' is there to allow "microblaze-linux-gnu".
I'm not sure this is really kosher or not. I would think not (we're in
danger of thinking that the OS name is "gnu" rather than "linux".  But
keeping it if needed shouldn't be too much of a burden as long as this
is limited to configure.tgt.

> 2010-11-18  Masaki Muranaka  <monaka@monami-software.com>
> 
>         * configure.tgt: Accept microblaze*-*-linux* for linux target
>         and microblaze*-*-* for  as target.

Other than that, this seems fine to me.  Cc'ing Michael Eager
in case he has any additional comment.


> - - - - -
> diff --git a/gdb/configure.tgt b/gdb/configure.tgt
> index bca2260..e065e70 100644
> --- a/gdb/configure.tgt
> +++ b/gdb/configure.tgt
> @@ -323,14 +323,14 @@ mep-*-*)
>         # No sim needed. Target uses SID.
>         ;;
>  
> -microblaze*-linux-*)
> +microblaze*-linux-*|microblaze*-*-linux*)
>         # Target: Xilinx MicroBlaze running Linux
>         gdb_target_obs="microblaze-tdep.o microblaze-linux-tdep.o microblaze-rom.o 
>                         monitor.o dsrec.o solib.o solib-svr4.o corelow.o \
>                         symfile-mem.o linux-tdep.o"
>         gdb_sim=../sim/microblaze/libsim.a
>         ;;
> -microblaze*-xilinx-*)
> +microblaze*-*-*)
>         # Target: Xilinx MicroBlaze running standalone
>         gdb_target_obs="microblaze-tdep.o microblaze-rom.o monitor.o dsrec.o"
>         gdb_sim=../sim/microblaze/libsim.a

-- 
Joel

Re: [patch] target triplet for Microblaze.

[Michael Eager]

Joel Brobecker wrote:
>> The CVS head can't accept microblaze*-(manufacturer)-elf and
>> microblaze*-(manufacturer)-linux* as the target triplet.  This
>> behavior is not based upon the description in Autobook.
>> http://sourceware.org/autobook/autobook/autobook_17.html
> 
> I don't mind allowing another manufacturer than xilinx in the target
> triplet for the microblaze, but I'm just curious. Are there any others?
> If that's the case, perhaps we want to adjust the comments saying
> "Xilinx Microblaze" and remove "Xilinx"...

MicroBlaze is a proprietary processor developed by Xilinx and, AFAIK,
they have not licensed it to other manufacturers.  Xilinx is the only
possible specification which meets the definition in Autobook.

> Also, `microblaze*-linux-*' is there to allow "microblaze-linux-gnu".
> I'm not sure this is really kosher or not. I would think not (we're in
> danger of thinking that the OS name is "gnu" rather than "linux".  But
> keeping it if needed shouldn't be too much of a burden as long as this
> is limited to configure.tgt.

Perhaps this would be better as "microblaze*-*-linux" like other targets.


> 
>> 2010-11-18  Masaki Muranaka  <monaka@monami-software.com>
>>
>>         * configure.tgt: Accept microblaze*-*-linux* for linux target
>>         and microblaze*-*-* for  as target.
> 
> Other than that, this seems fine to me.  Cc'ing Michael Eager
> in case he has any additional comment.

Thanks.  I haven't been following gdb-patches until now.  :-\

>> - - - - -
>> diff --git a/gdb/configure.tgt b/gdb/configure.tgt
>> index bca2260..e065e70 100644
>> --- a/gdb/configure.tgt
>> +++ b/gdb/configure.tgt
>> @@ -323,14 +323,14 @@ mep-*-*)
>>         # No sim needed. Target uses SID.
>>         ;;
>>  
>> -microblaze*-linux-*)
>> +microblaze*-linux-*|microblaze*-*-linux*)
>>         # Target: Xilinx MicroBlaze running Linux
>>         gdb_target_obs="microblaze-tdep.o microblaze-linux-tdep.o microblaze-rom.o 
>>                         monitor.o dsrec.o solib.o solib-svr4.o corelow.o \
>>                         symfile-mem.o linux-tdep.o"
>>         gdb_sim=../sim/microblaze/libsim.a
>>         ;;
>> -microblaze*-xilinx-*)
>> +microblaze*-*-*)
>>         # Target: Xilinx MicroBlaze running standalone
>>         gdb_target_obs="microblaze-tdep.o microblaze-rom.o monitor.o dsrec.o"
>>         gdb_sim=../sim/microblaze/libsim.a

gcc/config.gcc has "microblaze*-*-*" and "microblaze*-linux*".
This should be updated to be compatible.

Patch is OK with me.



-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

Re: [patch] target triplet for Microblaze.

[Pedro Alves]

On Thursday 18 November 2010 17:43:50, Michael Eager wrote:

> MicroBlaze is a proprietary processor developed by Xilinx and, AFAIK,
> they have not licensed it to other manufacturers.  



> Xilinx is the only possible specification which meets the definition
> in Autobook.

That can't be right.

" cpu
     The type of processor used on the system. (...)

 manufacturer
     A somewhat freeform field which indicates the manufacturer of the system. (...)"

It's manufacturer of the system, not of the CPU.
Note "used on the system", therefore cpu != system.  And "system"
is really a broad term.  AFAIK, it's really a freeform field in
practice, so you should be able to put anything there.  For example,
if one takes xilink's toolchain sources (the gpl bits), fork / patch
them for some reason, and build / distribute them oneself, one
might want to legitimately change the manufacturer field to
avoid confusion.

-- 
Pedro Alves

Re: [patch] target triplet for Microblaze.

[Michael Eager]

Pedro Alves wrote:
> On Thursday 18 November 2010 17:43:50, Michael Eager wrote:
> 
>> MicroBlaze is a proprietary processor developed by Xilinx and, AFAIK,
>> they have not licensed it to other manufacturers.  
> 
> 
> 
>> Xilinx is the only possible specification which meets the definition
>> in Autobook.
> 
> That can't be right.
> 
> " cpu
>      The type of processor used on the system. (...)
> 
>  manufacturer
>      A somewhat freeform field which indicates the manufacturer of the system. (...)"
> 
> It's manufacturer of the system, not of the CPU.
> Note "used on the system", therefore cpu != system.  And "system"
> is really a broad term.  AFAIK, it's really a freeform field in
> practice, so you should be able to put anything there.  For example,
> if one takes xilink's toolchain sources (the gpl bits), fork / patch
> them for some reason, and build / distribute them oneself, one
> might want to legitimately change the manufacturer field to
> avoid confusion.

System, in this case, is the FPGA, manufactured by Xilinx.

If someone did fork the toolchain, how would that change
the manufacturer of the target system?

-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

Re: [patch] target triplet for Microblaze.

[Pedro Alves]

On Thursday 18 November 2010 18:44:40, Michael Eager wrote:
> Pedro Alves wrote:
> > On Thursday 18 November 2010 17:43:50, Michael Eager wrote:
> > 
> >> MicroBlaze is a proprietary processor developed by Xilinx and, AFAIK,
> >> they have not licensed it to other manufacturers.  
> > 
> > 
> > 
> >> Xilinx is the only possible specification which meets the definition
> >> in Autobook.
> > 
> > That can't be right.
> > 
> > " cpu
> >      The type of processor used on the system. (...)
> > 
> >  manufacturer
> >      A somewhat freeform field which indicates the manufacturer of the system. (...)"
> > 
> > It's manufacturer of the system, not of the CPU.
> > Note "used on the system", therefore cpu != system.  And "system"
> > is really a broad term.  AFAIK, it's really a freeform field in
> > practice, so you should be able to put anything there.  For example,
> > if one takes xilink's toolchain sources (the gpl bits), fork / patch
> > them for some reason, and build / distribute them oneself, one
> > might want to legitimately change the manufacturer field to
> > avoid confusion.
> 
> System, in this case, is the FPGA, manufactured by Xilinx.

Or "system" is a board that includes an FPGA manufactured by Xilinx,
yet assembled and sold by some other vendor, that happens to
decide to add some spice or to do some incompatible changes to Xilink's
version of the toolchain.  In the case of an intel x86 cpu, what you
call the "system"?  That answer to that should reveal that your
interpretation of system cannot be the only one possible.

A recent somewhat related example of this is the addition of the
w64 vendor to distinguish the mingw-w64 toolchain from the
mingw.org (vendor == pc) toolchain.

Quoting the whole description this time:

"manufacturer
    A somewhat freeform field which indicates the manufacturer of the system. This is often simply `unknown'. Other common strings are `pc' for an IBM PC compatible system, or the name of a workstation vendor, such as `sun'. "

Emphasis on "somewhat freeform".

-- 
Pedro Alves

Re: [patch] target triplet for Microblaze.

[Michael Eager]

Pedro Alves wrote:
> On Thursday 18 November 2010 18:44:40, Michael Eager wrote:
>> Pedro Alves wrote:
>>> On Thursday 18 November 2010 17:43:50, Michael Eager wrote:
>>>
>>>> MicroBlaze is a proprietary processor developed by Xilinx and, AFAIK,
>>>> they have not licensed it to other manufacturers.  
>>>
>>>
>>>> Xilinx is the only possible specification which meets the definition
>>>> in Autobook.
>>> That can't be right.
>>>
>>> " cpu
>>>      The type of processor used on the system. (...)
>>>
>>>  manufacturer
>>>      A somewhat freeform field which indicates the manufacturer of the system. (...)"
>>>
>>> It's manufacturer of the system, not of the CPU.
>>> Note "used on the system", therefore cpu != system.  And "system"
>>> is really a broad term.  AFAIK, it's really a freeform field in
>>> practice, so you should be able to put anything there.  For example,
>>> if one takes xilink's toolchain sources (the gpl bits), fork / patch
>>> them for some reason, and build / distribute them oneself, one
>>> might want to legitimately change the manufacturer field to
>>> avoid confusion.
>> System, in this case, is the FPGA, manufactured by Xilinx.
> 
> Or "system" is a board that includes an FPGA manufactured by Xilinx,
> yet assembled and sold by some other vendor, that happens to
> decide to add some spice or to do some incompatible changes to Xilink's
> version of the toolchain.  In the case of an intel x86 cpu, what you
> call the "system"?  That answer to that should reveal that your
> interpretation of system cannot be the only one possible.

Perhaps you are arguing that the patch should be rejected,
so that the current behavior that only "microblaze-xilinx-gnu"
would is accepted, and the change would make "microblaze-megacorp-gnu"
also match.  If so, then I agree that this would be an undesirable
consequence.

-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

Re: [patch] target triplet for Microblaze.

[Pedro Alves]

On Thursday 18 November 2010 21:35:18, Michael Eager wrote:

> Perhaps you are arguing that the patch should be rejected,

Evidently I'm not.  I was arguing that the remark:

"Xilinx is the only possible specification which meets the definition
in Autobook."

is incorrect.  And from that I thought it would be obvious that
I consider accepting -*- the correct thing to do.

Since you're okay with the patch, this whole discussion
is moot anyway.

-- 
Pedro Alves

Re: [patch] target triplet for Microblaze.

[Joel Brobecker]

> >Also, `microblaze*-linux-*' is there to allow "microblaze-linux-gnu".
> >I'm not sure this is really kosher or not. I would think not (we're in
> >danger of thinking that the OS name is "gnu" rather than "linux".  But
> >keeping it if needed shouldn't be too much of a burden as long as this
> >is limited to configure.tgt.
> 
> Perhaps this would be better as "microblaze*-*-linux" like other targets.

I agree this would be better, especially if you think that this is not
going to be a problem for existing users.  We should even merge it
with Masaki's suggestion and make it "microblaze*-*-linux*".

-- 
Joel

Re: [patch] target triplet for Microblaze.

[Michael Eager]

Joel Brobecker wrote:
>>> Also, `microblaze*-linux-*' is there to allow "microblaze-linux-gnu".
>>> I'm not sure this is really kosher or not. I would think not (we're in
>>> danger of thinking that the OS name is "gnu" rather than "linux".  But
>>> keeping it if needed shouldn't be too much of a burden as long as this
>>> is limited to configure.tgt.
>> Perhaps this would be better as "microblaze*-*-linux" like other targets.
> 
> I agree this would be better, especially if you think that this is not
> going to be a problem for existing users.  We should even merge it
> with Masaki's suggestion and make it "microblaze*-*-linux*".

OK with me.

-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

Re: [patch] target triplet for Microblaze.

[Masaki Muranaka]

Hello,

Patch applied. Thanks.

On 2010/11/19, at 7:53, Michael Eager wrote:

> Joel Brobecker wrote:
>>>> Also, `microblaze*-linux-*' is there to allow "microblaze-linux-gnu".
>>>> I'm not sure this is really kosher or not. I would think not (we're in
>>>> danger of thinking that the OS name is "gnu" rather than "linux".  But
>>>> keeping it if needed shouldn't be too much of a burden as long as this
>>>> is limited to configure.tgt.
>>> Perhaps this would be better as "microblaze*-*-linux" like other targets.
>> I agree this would be better, especially if you think that this is not
>> going to be a problem for existing users.  We should even merge it
>> with Masaki's suggestion and make it "microblaze*-*-linux*".
> 
> OK with me.
> 
> -- 
> Michael Eager	 eager@eagercon.com
> 1960 Park Blvd., Palo Alto, CA 94306  650-325-8077
>